Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.to_petab: store parameter estimates as nominal values #77

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jan 18, 2024

Should make it easier to then simulate the full parameter vector, e.g. via petab_select.Model.to_petab()[PETAB_PROBLEM].x_nominal.

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f3a28de) 57.44% compared to head (87379a5) 57.50%.
Report is 2 commits behind head on develop.

Files Patch % Lines
petab_select/ui.py 12.50% 7 Missing ⚠️
petab_select/model.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
+ Coverage    57.44%   57.50%   +0.06%     
===========================================
  Files           14       14              
  Lines         1478     1485       +7     
===========================================
+ Hits           849      854       +5     
- Misses         629      631       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilpath dilpath merged commit a42f7e4 into develop Feb 1, 2024
3 checks passed
@dilpath dilpath deleted the model_petab_set_estimated branch February 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants