Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up governing_method and method in CandidateSpaces #73

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 17, 2023

No description provided.

…attribute only, remove retry_model_space_search_if_no_models
@dilpath dilpath requested a review from dweindl December 17, 2023 17:20
petab_select/candidate_space.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f9a06d4) 57.58% compared to head (12079b2) 57.44%.

Files Patch % Lines
petab_select/candidate_space.py 40.00% 6 Missing ⚠️
petab_select/ui.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    57.58%   57.44%   -0.15%     
===========================================
  Files           14       14              
  Lines         1490     1478      -12     
===========================================
- Hits           858      849       -9     
+ Misses         632      629       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilpath dilpath merged commit f3a28de into develop Jan 3, 2024
3 checks passed
@dilpath dilpath deleted the candidatespace_class_attrs branch January 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants