Fix FAMoS termination; remove other switching methods #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #68 +/- ##
===========================================
- Coverage 60.95% 57.58% -3.37%
===========================================
Files 14 14
Lines 1534 1490 -44
===========================================
- Hits 935 858 -77
- Misses 599 632 +33 ☔ View full report in Codecov by Sentry. |
Merged
dilpath
deleted the
fix_famos_termination_remove_other_switching_methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FAMoS candidate space returns no models, if one of its inner methods (e.g. the forward method) provides no models. Calibration tools (e.g. pyPESTO) then terminate the model selection, because no models were provided. However, at this point, FAMoS should switch to another method.
This switching is now implemented, in
petab_select/ui.py.The other changes are to remove the other switching methods (
ForwardAndBackwardCandidateSpaceandBidirectionalCandidateSpace), because these methods are probably not used by anyone, and would suffer from the same issue currently.StopIterations would need to be implemented in them, similarly toFamosCandidateSpace, when the search should truly terminate.