Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Daniel Weindl <[email protected]>
  • Loading branch information
dilpath and dweindl authored Nov 18, 2024
1 parent f9aa005 commit 7fc4b9c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions petab_select/plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def upset(
The criterion.
Returns:
The plot axes (see documentation from the `upsetplot` package).
The plot axes (see documentation from the `upsetplot <https://upsetplot.readthedocs.io/>`__ package).
"""
# Get delta criterion values
values = np.array(
Expand Down Expand Up @@ -318,7 +318,7 @@ def graph_history(
if label_diff := set(colors).difference(list(G)):
raise ValueError(
"Colors were provided for the following model labels, but "
"these are not in the graph: {label_diff}"
f"these are not in the graph: {label_diff}"
)

node_colors = [
Expand Down Expand Up @@ -395,7 +395,7 @@ def bar_criterion_vs_models(
if label_diff := set(colors).difference(criterion_values):
raise ValueError(
"Colors were provided for the following model labels, but "
"these are not in the graph: {label_diff}"
f"these are not in the graph: {label_diff}"
)

bar_kwargs["color"] = [
Expand Down Expand Up @@ -467,7 +467,7 @@ def scatter_criterion_vs_n_estimated(
if label_diff := set(colors).difference(labels.values()):
raise ValueError(
"Colors were provided for the following model labels, but "
"these are not in the graph: {label_diff}"
f"these are not in the graph: {label_diff}"
)
scatter_kwargs["c"] = [
colors.get(model_label, NORMAL_NODE_COLOR)
Expand Down

0 comments on commit 7fc4b9c

Please sign in to comment.