allow math processor to run multiple times by not using mutable refer…

…ences
PERBILITY · Dec 13, 2019 · 7d6d32c · 7d6d32c
1 parent 662c517
commit 7d6d32c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/MathParser/Math.php b/lib/MathParser/Math.php
@@ -82,7 +82,7 @@ public function registerVariable($name, $value)
         $this->variables[$name] = $value;
     }
 
-    public function run(array &$stack)
+    public function run(array $stack)
     {
         $this->substituteVariables($stack, $this->variables);
 

diff --git a/test/MathParserTest.php b/test/MathParserTest.php
@@ -162,6 +162,17 @@ public function testVariables($input, $expected)
         $this->assertSame($expected, $mathParser->evaluate($input[0]));
     }
 
+    /**
+     * @dataProvider provideVariableData
+     */
+    public function testVariablesMultipleTimes($input, $expected)
+    {
+        $mathParser = new Math();
+        $mathParser->setVariables($input[1]);
+        $this->assertSame($expected, $mathParser->evaluate($input[0]));
+        $this->assertSame($expected, $mathParser->evaluate($input[0]));
+    }
+
     /**
      * @dataProvider provideInvalidVariableData
      */