Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New error function and resolved compiler warnings #764

Merged
merged 31 commits into from
Dec 19, 2024
Merged

New error function and resolved compiler warnings #764

merged 31 commits into from
Dec 19, 2024

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Nov 14, 2024 •
edited
Loading

Resolves #602

This PR resolves numerous compiler warnings that spring up when building CMOR or its C tests.

Part of this effort involved creating a new error handling function that uses variadic arguments for format strings similar to printf. This will allow for error messages to have strings greater than 1023 characters (CMOR_MAX_STRING - 1 for null-terminated strings).

mauzey1 added 28 commits January 19, 2023 18:16
@mauzey1
Redesign cmor_handle_error to be a variadic function
45afa6f
@mauzey1
Update cmor_error_handle function calls in cmor_CV.c
e32ffe7
@mauzey1
Remove unused string variables
01e8b94
@mauzey1
Merge branch 'main' into new_error_function
25f4931
@mauzey1
Update error messages in cmor_tables.c
2a2452a
@mauzey1
Update error message call
18716a5
@mauzey1
Add variadic versions of error handling functions
f037487
@mauzey1
Replace error handling function calls in cmor.c with variadic version
167be97
@mauzey1
Merge branch 'main' into new_error_function
efeaa5a
@mauzey1
Add missing parameter to error message function
7585b3d
@mauzey1
Check format strings in variadic error handling functions if they are…
baaa677 
… consistent with printf style format strings
@mauzey1
Fix comment block
a41cf61
@mauzey1
Replace error handling function with variadic version in cmor_variabl…
edd8f94 
…es.c
@mauzey1
Remove unused string variables
3b84e07
@mauzey1
Concatenate with the length of the source string
c232973
@mauzey1
Use variadic error handling function in cmor_axes.c
fcd1e62
@mauzey1
Use variadic error handling function in cmor_grids.c
23880b1
@mauzey1
Remove assignments in conditions
f811fab
@mauzey1
Use strcmp for string comparisons
486847a
@mauzey1
Remove comparisons of arrays with NULL
4c1783e
@mauzey1
Use labs for absolute values of long values
dfdb3ce
@mauzey1
Generate message for min/max values warning with dynamically-allocate…
8522000 
…d strings
@mauzey1
Change function parameters from arrays to pointers
2866461
@mauzey1
Change function signature in header file
eddd53f
@mauzey1
Change array parameters to pointer parameters in function signatures
949dbea
@mauzey1
Use dynamically-allocated string for joining grid dimension names
d08da4f
@mauzey1
Make string concatenation length be dependent on destination length
5390a77
@mauzey1
Use dynamically-allocated string for joining forcing values
6d7db6e
@mauzey1 mauzey1 self-assigned this Nov 14, 2024
@mauzey1 mauzey1 changed the title New error function test PR New error function and resolved compiler warnings Dec 19, 2024
@mauzey1 mauzey1 marked this pull request as ready for review December 19, 2024 20:29
@mauzey1 mauzey1 requested a review from durack1 December 19, 2024 20:29
durack1
durack1 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 this is great, thanks for pushing on this!

@mauzey1 mauzey1 merged commit 906e37b into main Dec 19, 2024
15 checks passed
@mauzey1 mauzey1 deleted the new_error_function branch December 19, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durack1 durack1 durack1 approved these changes

Assignees

@mauzey1 mauzey1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerous warnings when compiling CMOR
2 participants
@mauzey1 @durack1