Disable cache TTL by default #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeckerle
approved these changes
Jan 30, 2024
| to zero (e.g. "0 seconds"), cached compiled DFDL schemas are never removed from the cache. The default value | ||
| is 30 minutes. | ||
| <tt><time_unit></tt> is a supported unit of time, such as nanos, millis, secs, mins, hrs, days. The | ||
| default is "0 seconds", which means compiled DFDL schemas are never removed from the cache. |
There was a problem hiding this comment.
What do you do if the schema has been changed and you want to remove it from the cache? You need to explain here what do do about this never-expires setting to manually manage the cache.
There was a problem hiding this comment.
I believe the cache is reset by restarting the processor, I'll confirm and add a note.
The current cache TTL default is 30 minutes, which is relatively short and could easily lead to hiccups if there is a lull in data, a schema is removed from the cache and Daffodil needs to recompile it when data starts flowing again. To avoid these hiccups, this changes the default to 0 seconds, which means to never remove schemas from the cache. In most cases, if a user uses a schema once they are probably going to use it again, so this avoids recompilations that could lead to unexpected latencies.
stevedlawrence
force-pushed
the
zero-ttl
branch
from
774ec30 to
5414816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cache TTL default is 30 minutes, which is relatively short and could easily lead to hiccups if there is a lull in data, a schema is removed from the cache and Daffodil needs to recompile it when data starts flowing again.
To avoid these hiccups, this changes the default to 0 seconds, which means to never remove schemas from the cache. In most cases, if a user uses a schema once they are probably going to use it again, so this avoids recompilations that could lead to unexpected latencies.