This repository has been archived by the owner on Aug 31, 2019. It is now read-only.
Redo particle effects API and add new effects #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've redone the particle effects API.
Patches originally used to add the particle stuff have been repurposed to add some missing effects. I've intentionally done this so early in the patch process because I've submitted a PR to Bukkit with the same diff (see Bukkit/Bukkit#1074), so if it gets pulled this century updating would be a matter of removing them both.
Patches whose purpose is to add the actual particle stuff have been added last. I've attempted to keep the diffs at a minimum, so they may look ugly or something, but work well otherwise and with very little overhead.
On the plus side this fixes #88