Redo particle effects API and add new effects #89
Conversation
|
The renamed effects are going to cause issues with plugins not compiled with this patch and vise versa. |
|
I could add some I want to get this if possible pulled on official Bukkit, so I thought it would make more sense to use the proper names, so if it gets pulled it would not break, even though it breaks now. |
|
I'm fine breaking plugins/names |
|
@socram8888 care to rebase on master? |
|
Done |
|
I re-reviewed this PR and it looks good code wise. Have you done any testing? Even if you have I probably will before we merge this. |
|
All I tested is that vanilla Bukkit effects (SOUND and VISUAL) work properly (while in the original code they don't). I haven't tested the particle things since I have no plugin which employs them. Maybe it's desirable to merge only the first two patches (the ones that add the new effects and fixes the original ones from Bukkit), and after that, pull the particle patch. |
tonybruess
force-pushed
the
master
branch
2 times, most recently
from
012fd8f
to
c24a0c6
Compare
I've redone the particle effects API.
Patches originally used to add the particle stuff have been repurposed to add some missing effects. I've intentionally done this so early in the patch process because I've submitted a PR to Bukkit with the same diff (see Bukkit/Bukkit#1074), so if it gets pulled this century updating would be a matter of removing them both.
Patches whose purpose is to add the actual particle stuff have been added last. I've attempted to keep the diffs at a minimum, so they may look ugly or something, but work well otherwise and with very little overhead.
On the plus side this fixes #88