forked from apache/cordova-plugin-statusbar
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDMR-207 :: MABS 11 :: Cordova :: Status bar plugin #19
Merged
andredestro
merged 2 commits into
outsystems
from
feat/RDMR-207/status-bar-style-default
Aug 13, 2024
Merged
RDMR-207 :: MABS 11 :: Cordova :: Status bar plugin #19
andredestro
merged 2 commits into
outsystems
from
feat/RDMR-207/status-bar-style-default
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
from
July 31, 2024 15:24
598439a
to
3c9eb3c
Compare
andredestro
requested review from
a team,
markemer,
EiyuuZack,
theproducer,
vmfo22,
carlpoole and
trevor-lambert
and removed request for
a team
August 1, 2024 15:02
jcesarmobile
reviewed
Aug 1, 2024
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
from
August 5, 2024 08:46
3c9eb3c
to
3a491fb
Compare
markemer
reviewed
Aug 5, 2024
What the heck is causing all these tests to fail? |
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
3 times, most recently
from
August 7, 2024 14:01
a0bcb69
to
3a491fb
Compare
markemer
approved these changes
Aug 8, 2024
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
2 times, most recently
from
August 9, 2024 16:28
0c616d5
to
2761a90
Compare
jcesarmobile
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, also Android seems to be adding unrelated changes?
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
from
August 9, 2024 18:52
2761a90
to
cc67abf
Compare
andredestro
force-pushed
the
feat/RDMR-207/status-bar-style-default
branch
from
August 12, 2024 09:06
cc67abf
to
0bfc9a9
Compare
theproducer
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
References https://outsystemsrd.atlassian.net/browse/RDMR-207
Enable the iOSUIStatusBarStyleDefault style which automatically chooses light or dark content based on the user interface style.
Description
This PR changes the default style to UIStatusBarStyleDefault instead of UIStatusBarStyleDarkContent and adds a specific method to set the Dark Content style.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)