Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDMR-207 :: MABS 11 :: Cordova :: Status bar plugin #19

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

andredestro
Copy link

Platforms affected

  • iOS
  • Android
  • Windows

Motivation and Context

References https://outsystemsrd.atlassian.net/browse/RDMR-207

Enable the iOSUIStatusBarStyleDefault style which automatically chooses light or dark content based on the user interface style.

Description

This PR changes the default style to UIStatusBarStyleDefault instead of UIStatusBarStyleDarkContent and adds a specific method to set the Dark Content style.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@andredestro andredestro self-assigned this Jul 31, 2024
@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch from 598439a to 3c9eb3c Compare July 31, 2024 15:24
@andredestro andredestro marked this pull request as ready for review July 31, 2024 15:42
@andredestro andredestro requested review from a team, markemer, EiyuuZack, theproducer, vmfo22, carlpoole and trevor-lambert and removed request for a team August 1, 2024 15:02
types/index.d.ts Outdated Show resolved Hide resolved
@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch from 3c9eb3c to 3a491fb Compare August 5, 2024 08:46
@markemer
Copy link

markemer commented Aug 6, 2024

What the heck is causing all these tests to fail?

@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch 3 times, most recently from a0bcb69 to 3a491fb Compare August 7, 2024 14:01
@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch 2 times, most recently from 0c616d5 to 2761a90 Compare August 9, 2024 16:28
Copy link

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, also Android seems to be adding unrelated changes?

README.md Outdated Show resolved Hide resolved
src/ios/CDVStatusBar.m Show resolved Hide resolved
@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch from 2761a90 to cc67abf Compare August 9, 2024 18:52
@andredestro andredestro force-pushed the feat/RDMR-207/status-bar-style-default branch from cc67abf to 0bfc9a9 Compare August 12, 2024 09:06
@andredestro andredestro merged commit 0df27bf into outsystems Aug 13, 2024
31 of 34 checks passed
@andredestro andredestro deleted the feat/RDMR-207/status-bar-style-default branch August 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants