Calculate impacts for all stands within Project Areas #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roquebetioljr
commented
Jan 6, 2025
•
roquebetioljr
commented
- Calculate impacts for all stands within Project Areas, even when no action was applied to stands.
- Filtering stands with applied actions to calculate the Project Area Treatment Result in order to keep current implementation.
- Calculate baseline metrics for Flame Length and Rate of Spread metrics instead of calculating its impacts.
- Some refactoring on repetitive queries to retrieve Stands.
george-silva
approved these changes
Jan 6, 2025
roquebetioljr
force-pushed
the
plan-1906
branch
from
093826d to
d555db3
Compare
roquebetioljr
changed the title
roquebetioljr
commented
Jan 7, 2025
| @@ -402,107 +398,6 @@ def test_calculate_delta(self): | |||
| ) | |||
|
|
|||
|
|
|||
| class AsyncGetOrCalculatePersistImpactsTestCase(TransactionTestCase): | |||
There was a problem hiding this comment.
Just moved to test_tasks.py file as the tested method is under the task file.
george-silva
reviewed
Jan 7, 2025
george-silva
reviewed
Jan 7, 2025
george-silva
reviewed
Jan 7, 2025
george-silva
reviewed
Jan 7, 2025
roquebetioljr
force-pushed
the
plan-1906
branch
from
d61113b to
be78e9e
Compare
george-silva
approved these changes
Jan 7, 2025
roquebetioljr
force-pushed
the
plan-1906
branch
from
4530d70 to
4812dad
Compare
george-silva
approved these changes
Jan 8, 2025
- Filtering stands with applied actions to calculate the Project Area Treatment Result
Test-case update due to behavior change
…d Rate of Spread variables
Get stands from scenario refactored
roquebetioljr
force-pushed
the
plan-1906
branch
from
7539db2 to
e2c6123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.