Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAN-1837: Adding delete treatment plan confirmation modal #2058

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

LALuis
Copy link
Contributor

@LALuis LALuis commented Jan 5, 2025

Once we delete a treatment plan 2 things will happen.

1- A confirmation popup will appear asking if you are sure that you want to delete it.
2- If you click delete, a loading spinnner will appear until the treatment is deleted or the operation fails.

QUESTION FOR THE TEAM:
I see the spinner is pretty close to the tab bottom line. Can I add some margin-top to the spinner to make it looks a little bit better?

Jira: https://sig-gis.atlassian.net/browse/PLAN-1837

Result:
delete_treatment

@LALuis LALuis self-assigned this Jan 5, 2025
@pflopez
Copy link
Contributor

pflopez commented Jan 6, 2025

Yes for sure that spinner position looks wrong :)

@LALuis
Copy link
Contributor Author

LALuis commented Jan 6, 2025

Yes for sure that spinner position looks wrong :)

Updated

@LALuis LALuis enabled auto-merge (squash) January 6, 2025 17:30
@pflopez
Copy link
Contributor

pflopez commented Jan 6, 2025

There's a bug here- we are showing the loader when the treatment plan is removed, but thats unnecessary, given that we are manually removing the item from the list.

For clarity- there was no bug :) bug luis added some improvements :D

@LALuis
Copy link
Contributor Author

LALuis commented Jan 6, 2025

There's a bug here- we are showing the loader when the treatment plan is removed, but thats unnecessary, given that we are manually removing the item from the list.

Updated

Copy link
Contributor

@pflopez pflopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@LALuis LALuis merged commit 8808aad into main Jan 7, 2025
6 checks passed
@LALuis LALuis deleted the plan-1837-delete-treatment-plan branch January 7, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants