-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAN-1837: Adding delete treatment plan confirmation modal #2058
Conversation
Yes for sure that spinner position looks wrong :) |
Updated |
For clarity- there was no bug :) bug luis added some improvements :D |
…cape/Planscape into plan-1837-delete-treatment-plan
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Once we delete a treatment plan 2 things will happen.
1- A confirmation popup will appear asking if you are sure that you want to delete it.
2- If you click delete, a loading spinnner will appear until the treatment is deleted or the operation fails.
QUESTION FOR THE TEAM:
I see the spinner is pretty close to the tab bottom line. Can I add some margin-top to the spinner to make it looks a little bit better?
Jira: https://sig-gis.atlassian.net/browse/PLAN-1837
Result: