Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treatment Expander + Treatment/Sequence Icon Components #1702

Merged
merged 22 commits into from
Sep 10, 2024

Conversation

lastminutediorama
Copy link
Contributor

@lastminutediorama lastminutediorama commented Aug 28, 2024

Note: I decided to make a Project Area Expander a separate component. They share a few basic things in common, but the data for Project Area potentially has nested data that seems fragile to mix into a single component.

@lastminutediorama lastminutediorama changed the title Expander Component + Treatment/Sequence Icon Components Treatment Expander + Treatment/Sequence Icon Components Aug 29, 2024
@lastminutediorama lastminutediorama marked this pull request as ready for review August 29, 2024 20:54
Copy link
Contributor

@pflopez pflopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! we can solve the remaining TODOs separately.
Only comment is that I dont think NO_TREATMENT should be a type of prescription action

@lastminutediorama lastminutediorama merged commit 216bf18 into main Sep 10, 2024
6 checks passed
@lastminutediorama lastminutediorama deleted the expander-component branch September 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants