Scenario project areas #1699
Merged
Scenario project areas #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,7 +41,8 @@ export interface ScenarioResult { | |||
| status: ScenarioResultStatus; | |||
| completed_at: string; | |||
| result: { | |||
| features: FeatureCollection[]; | |||
| // this is the FeatureCollection[] | |||
| features: FeatureCollection[]; // TODO this is actually Features[] | |||
There was a problem hiding this comment.
Do you need to update this before merging?
There was a problem hiding this comment.
no, i think that change will require a pr on its own
| 'text-size': 14, | ||
| 'text-anchor': 'center', | ||
| 'text-justify': 'center' | ||
| }" |
There was a problem hiding this comment.
nit:I imagine we should talk about eventually storing these styles in a central place.
There was a problem hiding this comment.
yep, not sure what's the best place yet but happy to do a second pass to centralize this!
| imports: [ | ||
| FeatureComponent, | ||
| GeoJSONSourceComponent, | ||
| NgForOf, |
There was a problem hiding this comment.
Are you still using this NgForOf?
lastminutediorama
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show project areas on treatment map and update layers to new martin endpoints