Map baselayers #1696
Merged
Map baselayers #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pflopez
force-pushed
the
map-baselayers
branch
from
6403fe6 to
36afed1
Compare
pflopez
commented
Aug 29, 2024
| @@ -0,0 +1,15 @@ | |||
| <details open> | |||
There was a problem hiding this comment.
this could become its own component (the styles are going to be somewhat repeated for the other map layer configs).
Will probably do a component for the next one
There was a problem hiding this comment.
ok. sounds reasonable
pflopez
commented
Aug 29, 2024
| templateUrl: './map-base-layer.component.html', | ||
| styleUrl: './map-base-layer.component.scss', | ||
| }) | ||
| export class MapBaseLayerComponent { |
There was a problem hiding this comment.
Another detail, in the next pr im renaming this to baseLayerControl - to differentiate this components with map layer ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.