Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates new Layer for project areas, filtered by scenario #1693

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

george-silva
Copy link
Contributor

@george-silva george-silva commented Aug 22, 2024

  1. Creates new management command to install/uninstall dynamic martin layers
  2. Changes makefile to use those commands so they are automatically installed
  3. Refactors previously existing layer, changing their names, adding DELETED AT filters and simplifying code
  4. Creates new project areas layer, dynamic by scenario id

Copy link
Contributor

@pflopez pflopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being picky with naming, not sure dynamic_xyz is very informative on the function names. Added some suggestion on naming based on the comments

martin.yaml Outdated Show resolved Hide resolved
martin.yaml Outdated Show resolved Hide resolved
martin.yaml Outdated Show resolved Hide resolved
@george-silva george-silva merged commit 556a850 into main Aug 22, 2024
6 checks passed
@george-silva george-silva deleted the plan-1569 branch August 22, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants