Treatments map #1678
Treatments map #1678
Conversation
pflopez
force-pushed
the
treatments-map
branch
8 times, most recently
from
941cead to
8753c03
Compare
| @@ -0,0 +1,5 @@ | |||
| <div *ngIf="prescriptions$ | async; let prescriptions" class="prescriptions"> | |||
| <button *ngFor="let action of prescriptions.SINGLE | keyvalue" [value]=""> | |||
There was a problem hiding this comment.
did you mean to leave value blank here?
There was a problem hiding this comment.
yeah that's a placeholder, im not doing assignments on this PR, to limit the scope of changes.
| type="line" | ||
| [source]="sourceName" | ||
| [paint]="{ | ||
| 'line-color': '#007dff', |
There was a problem hiding this comment.
I don't know if it's worth the effort yet, but if there's a way to store these styles as constants somewhere, maybe that would help us as this grows?
There was a problem hiding this comment.
Yes i think that's probably the next step once we have more layers
| mapLibreMap!: MapLibreMap; | ||
| readonly key = environment.stadiamaps_key; | ||
|
|
||
| // ew, not sure if I want to do prop drilling here or set up something else (provider?) |
There was a problem hiding this comment.
I think this is okay for now, but maybe we can talk about what a provider could look like, especially if we're talking about where and how we're storing these and presenting them to the frontend?
There was a problem hiding this comment.
sure! I also think its ok now, and i don't want to prematurely optimize until we have this a little bit more developed.
A provider here can be something similar to what we have for the stands (SelectedStandsState).
Will update the comment though that one was mostly for me :D
There was a problem hiding this comment.
Just some general questions, but nothing that needs to be addressed. And since you mentioned it, I didn't have any better ideas for naming -- I think the components, functions, and vars are all self-explanatory and don't risk being confused with anything else.
pflopez
force-pushed
the
treatments-map
branch
from
26f9e95 to
f631a58
Compare
This pr adds the maplibre map on treatments and project areas, showing stands.
Additionally, adds some stubs/temporary components to interact with the map
TODO, not included on this pr:
Note, might need to do
npm install --legacy-peer-depsto avoid errors locally. Hopefully using this flag would be temporary as there is already a change to fix this on its way Esri/esri-leaflet-vector#219 (comment)Additionally the map libre libraries are not included on the main bundle