TreatmentPrescription bulk delete endpoint + tests (PLAN-1504) #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastminutediorama
changed the title
lastminutediorama
changed the title
| @@ -138,6 +138,12 @@ class Meta: | |||
| ) | |||
|
|
|||
|
|
|||
| class TreatmentPrescriptionBatchDeleteSerializer(serializers.Serializer): | |||
| stand_ids = serializers.ListField( | |||
Comment on lines
+188
to
+190
| delete_result = TreatmentPrescription.objects.filter( | ||
| stand_id__in=stand_ids, treatment_plan_id=tx_plan_pk | ||
| ).delete() |
There was a problem hiding this comment.
This is a product question to do to Jordan: in other endpoints we record an actstream about deletions. Should we log this interaction as well?
If the answer is yes, then the actstrem format is a bit different, but it should be possible to log it with a method on our service module.
george-silva
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion, we changed this to accept stand_ids instead of ids, since that's preferable for FE needs.