Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scenario on upload #1624

Merged
merged 54 commits into from
Sep 25, 2024
Merged

New scenario on upload #1624

merged 54 commits into from
Sep 25, 2024

Conversation

lastminutediorama
Copy link
Contributor

@lastminutediorama lastminutediorama commented Jul 20, 2024

Need to doublecheck a merge issue on this, also

@lastminutediorama lastminutediorama marked this pull request as ready for review September 3, 2024 10:20
Comment on lines 193 to 199
if not pa.geometry.contains(uploaded_geos):
return Response(
{
"error": "The uploaded geometry is not within the selected planning area."
},
status=status.HTTP_400_BAD_REQUEST,
)
Copy link
Contributor

@george-silva george-silva Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to leave this here but we could validate this in the serializer. You could pass the planning are as part of the serializer context on the moment you initialize it.

Copy link

gitguardian bot commented Sep 24, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5092871 Triggered Generic High Entropy Secret 5cf02b7 .github/workflows/django.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@lastminutediorama lastminutediorama marked this pull request as draft September 24, 2024 04:05
@lastminutediorama lastminutediorama marked this pull request as ready for review September 25, 2024 20:03
@lastminutediorama lastminutediorama merged commit 3177572 into main Sep 25, 2024
6 checks passed
@lastminutediorama lastminutediorama deleted the new-scenario-on-upload branch September 25, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants