Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAN-1253 #1526

Merged
merged 2 commits into from
May 23, 2024
Merged

PLAN-1253 #1526

merged 2 commits into from
May 23, 2024

Conversation

george-silva
Copy link
Contributor

  1. creates the infrastructure to support list/retrieve endpoints for treatment goals (serializer, routers, views, etc)
  2. creates tests for said infra
  3. changes queryset for other viewsets to be limited to public projects for now. later on we should filter based on request.user

lastminutediorama
lastminutediorama reviewed May 23, 2024
View reviewed changes
src/planscape/goals/views.py

class TreatmentGoalViewSet(ListModelMixin, RetrieveModelMixin, GenericViewSet):
queryset = TreatmentGoal.objects.filter(
project__visibility=ProjectVisibility.PUBLIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems like a good approach for now

lastminutediorama
lastminutediorama approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lastminutediorama lastminutediorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm, thanks for all of these tests

@george-silva george-silva merged commit 73d74c2 into main May 23, 2024
6 checks passed
@george-silva george-silva deleted the plan-1253 branch May 23, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lastminutediorama lastminutediorama lastminutediorama approved these changes

@pflopez pflopez Awaiting requested review from pflopez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@george-silva @lastminutediorama