TestBox run should use webroot when resolving testbox location in ensureTestBox() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reTestBox Currently, if your testbox folder is not in the current folder where your server.json lives, ie, a subfolder like /test-harness or /app the ensureTestBox() function fails, and then installs testbox into the testbox-cli folder. In CI, this testbox-cli folder never has a testbox in it, because its built from an image, so this means every time we run tests, it installs testbox over and over and over again. This fix users the server info to pass the webroot of the current server to the resolvePath() command, to ensure we look for testbox in the webroot. Improvement: Maybe we look in the current folder, and in the webroot?
|
merged manually. Due to some other changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if your testbox folder is not in the current folder where your server.json lives, ie, a subfolder like /test-harness or /app the ensureTestBox() function fails, and then installs testbox into the testbox-cli folder.
In CI, this testbox-cli folder never has a testbox in it, because its built from an image, so this means every time we run tests, it installs testbox over and over and over again.
This fix users the server info to pass the webroot of the current server to the resolvePath() command, to ensure we look for testbox in the webroot.
Improvement: Maybe we look in the current folder, and in the webroot?
Please note that all PRs must have tests attached to them
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Issues
All PRs must have an accompanied issue. Please make sure you created it and linked it here.
Type of change
Please delete options that are not relevant.
Checklist