Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos #156

Closed
wants to merge 3 commits into from
Closed

Conversation

nolanerck
Copy link
Contributor

Description

The word "thresholds" was spelled incorrectly in several places in the code. That's been fixed.

Please note that all PRs must have tests attached to them

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Jira Issues

All PRs must have an accompanied Jira issue. Please make sure you created it and linked it here.

Bug Tracker: https://ortussolutions.atlassian.net/jira/software/c/projects/TESTBOX/issues

https://ortussolutions.atlassian.net/browse/TESTBOX-405

Type of change

  • [x ] Improvement

Checklist

  • [x ] My code follows the style guidelines of this project cfformat
  • [ n/a] I have commented my code, particularly in hard-to-understand areas
  • [ n/a] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes

@nolanerck
Copy link
Contributor Author

This is a bigger deal. It looks like there's a compatiblity issue with ACF2023 when enableNullSupport is true (from what I can tell, it's mostly due to the isNull() function not behaving the way it does in Lucee). I'm closing this PR since it's, at best, a band-aid on bigger issue.

@nolanerck nolanerck closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant