Add revert for getServiceAgreement if service agreement doesn't exist

OriginTrail · Mar 4, 2024 · 0468e1e · 0468e1e
1 parent 7d0db0b
commit 0468e1e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/contracts/v1/errors/ServiceAgreementErrors.sol b/contracts/v1/errors/ServiceAgreementErrors.sol
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: MIT
+
+pragma solidity ^0.8.16;
+
+library ServiceAgreementErrors {
+    error ServiceAgreementDoesntExist(bytes32 agreementId);
+}
diff --git a/contracts/v1/storage/ServiceAgreementStorageProxy.sol b/contracts/v1/storage/ServiceAgreementStorageProxy.sol
@@ -10,6 +10,7 @@ import {Initializable} from "../interface/Initializable.sol";
 import {Named} from "../interface/Named.sol";
 import {Versioned} from "../interface/Versioned.sol";
 import {GeneralErrors} from "../errors/GeneralErrors.sol";
+import {ServiceAgreementErrors} from "../errors/ServiceAgreementErrors.sol";
 
 contract ServiceAgreementStorageProxy is Named, Versioned, HubDependent, Initializable {
     string private constant _NAME = "ServiceAgreementStorageProxy";
@@ -124,8 +125,10 @@ contract ServiceAgreementStorageProxy is Named, Versioned, HubDependent, Initial
                 [tokenAmount, storageV1U1.getAgreementUpdateTokenAmount(agreementId)],
                 scoreFunctionIdAndProofWindowOffsetPerc
             );
-        } else {
+        } else if (this.agreementV1U1Exists(agreementId)) {
             return storageV1U1.getAgreementData(agreementId);
+        } else {
+            revert ServiceAgreementErrors.ServiceAgreementDoesntExist(agreementId);
         }
     }