Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create link component #222

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

feat: create link component #222

wants to merge 27 commits into from
+2,544 −157

Conversation

paulinea
Copy link
Member

@paulinea paulinea commented Dec 5, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

florentmaitre and others added 23 commits December 4, 2024 18:15
@florentmaitre
Update OudsButton according to design specifications
e2f153d
@paulinea @florentmaitre
Add components navigation system
9d40cec
@paulinea @florentmaitre
Add button demo screen with its customization options
9775c7b
@florentmaitre
Remove OnResumeEffect and use LifecycleResumeEffect instead
a2287bc
@florentmaitre
Remove ComponentDetailScreen
efc4869
@florentmaitre
Update OudsButton demo with the actual button
9f2b419
@florentmaitre
OudsButton now supports both determinate and indeterminate circular p…
36b8e09 
…rogress indicators
@florentmaitre
Update Android Studio config file
17217e1
@florentmaitre
Review: Rename parameters of private OudsButton method
4a2e136
@florentmaitre
Review: Use a list instead of multiple conditions
338a020
@florentmaitre
Review: Factorize skeleton color
726149a
@florentmaitre
Review: Remove useless val
f46b0cd
@florentmaitre
Review: Fix KDoc for OudsButton.Style.Skeleton
9677a29
@florentmaitre
Review: Button demo is now displayed for both light and dark backgrou…
2590004 
…nds at the same time
@florentmaitre
Review: Fix a bug where text was read by TalkBack on a skeleton button
5efdd33
@florentmaitre
Add a11y state description for loading button
7962cf8
@florentmaitre
Review: Add contentDescription parameter to OudsButton.Icon constructors
0f24ea6
@florentmaitre
Review: Remove useless extension method on Color
9640215
@florentmaitre
Review: Move OudsIconButtonDefaults into OudsIconButton.kt and OudsIc…
db2f02c 
…onDefaults into OudsIcon.kt
@florentmaitre
Review: Add inner border for focus state
6777c70
@florentmaitre
Review: Fix KDoc for outerBorder method
d3a6750
@florentmaitre
Review: Remove useless enabled parameter and OudsIconButton
58add1f
@florentmaitre
Review: Fix a bug where TalkBack vocalizes the button loader
8a24761
@paulinea paulinea linked an issue Dec 5, 2024 that may be closed by this pull request
Create component - Link #219
Open
@paulinea paulinea changed the title 219 create component link feat: create link component Dec 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

🟢 Netlify deploy for commit 1869468 succeeded

Deploy preview: https://675ac292eb08196f47c8d68e--ouds-android.netlify.app
Deploy log: https://app.netlify.com/sites/ouds-android/deploys/675ac292eb08196f47c8d68e

@paulinea paulinea force-pushed the 219-create-component---link branch from 4d4f279 to 0f4fdd7 Compare December 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create component - Link
2 participants
@paulinea @florentmaitre