Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dimension tokens in the demo app #147

Merged
merged 32 commits into from
Nov 8, 2024
Merged

feat: add dimension tokens in the demo app #147

merged 32 commits into from
Nov 8, 2024

Conversation

paulinea
Copy link
Member

No description provided.

@paulinea paulinea linked an issue Oct 21, 2024 that may be closed by this pull request
Add dimension tokens in the demo app #120
Closed
@paulinea

This comment was marked as resolved.

Sign in to view
@paulinea paulinea force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from 8b1a027 to cf81b6a Compare October 21, 2024 17:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

🟢 Netlify deploy for commit 550678d succeeded

Deploy preview: https://672e1c13c6c4f09fdaf8ee5e--ouds-android.netlify.app
Deploy log: https://app.netlify.com/sites/ouds-android/deploys/672e1c13c6c4f09fdaf8ee5e

@paulinea paulinea force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from cf81b6a to 5942aa2 Compare October 22, 2024 08:57
@paulinea paulinea force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from 6d3763e to c433916 Compare October 23, 2024 14:15
@paulinea paulinea marked this pull request as ready for review October 23, 2024 14:32
@paulinea paulinea force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from c433916 to 69556aa Compare October 23, 2024 14:34
@paulinea paulinea force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from b6626f5 to b696f73 Compare October 24, 2024 13:38
florentmaitre
florentmaitre reviewed Oct 30, 2024
View reviewed changes
theme-contract/src/main/java/com/orange/ouds/theme/tokens/OudsSizeKeyToken.kt Outdated Show resolved Hide resolved
theme-contract/src/main/java/com/orange/ouds/theme/tokens/OudsSizeKeyToken.kt Show resolved Hide resolved
theme-contract/src/main/java/com/orange/ouds/theme/tokens/OudsSpaceKeyToken.kt Outdated Show resolved Hide resolved
core/src/main/java/com/orange/ouds/core/theme/OudsSpaces.kt Outdated Show resolved Hide resolved
NOTICE.txt Show resolved Hide resolved
app/src/main/res/drawable/ic_design_token_figma_no_padding.xml Show resolved Hide resolved
app/src/main/java/com/orange/ouds/app/ui/tokens/TokenProperty.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ouds/app/ui/tokens/TokenPropertyIllustration.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ouds/app/ui/tokens/TokenCategoryDetailScreen.kt Outdated Show resolved Hide resolved
app/src/main/java/com/orange/ouds/app/ui/tokens/TokenCategoryDetailScreen.kt Show resolved Hide resolved
@florentmaitre florentmaitre mentioned this pull request Oct 30, 2024
Merged
paulinea added 24 commits November 8, 2024 14:46
@paulinea @florentmaitre
Display all spacing tokens in the demo app
0bb2e13
@paulinea @florentmaitre
Apply filter before calling private composable
7d7fbfa
@paulinea @florentmaitre
Reorder properties
4d98607
@paulinea @florentmaitre
Update illustrations for spacing inline with icon
727433d
@paulinea @florentmaitre
Rename spacing into space
e433d19
@paulinea @florentmaitre
Rename strings
5f6dce1
@paulinea @florentmaitre
Add WithArrow tokens illustrations
b1654ac 
Factorize token properties illustrations
@paulinea @florentmaitre
Replace hardcoded spaces by tokens
d7b9d40
@paulinea @florentmaitre
Factorize some code
f8ec679
@paulinea @florentmaitre
Improve size and space key tokens organization
08000a5
@paulinea @florentmaitre
Review: Use object instead of class
5f0c15c
@paulinea @florentmaitre
Review: Add nested data classes in OudsSizes and OudsSpaces
c627d3b
@paulinea @florentmaitre
Review: Create nested enum classes for space key tokens
eeb7232
@paulinea @florentmaitre
Review: Add ic_chevron_down to NOTICE.txt
8854344
@paulinea @florentmaitre
Review: Add missing copyrights
6c73395
@paulinea @florentmaitre
Review: Update preview
2996c7a
@paulinea @florentmaitre
Review: Compute isSubcategory property at runtime
96441d4
@paulinea @florentmaitre
Review: Replace SizeIconWithLabel by SizeIconWithText
fdee1da
@paulinea @florentmaitre
Review: Fix body and label text styles
efb0805
@paulinea @florentmaitre
Review: Simplify code
585fe3c
@paulinea @florentmaitre
Review: Manage token property illustrations in the same file
415998b
@paulinea @florentmaitre
Review: Split tokens with icon/arrow and add corresponding illustrations
e0e1bc6
@paulinea @florentmaitre
Review: Rename iconWithLabel by iconWithText
57a101d
@paulinea @florentmaitre
Review: Rename composable
550678d
@florentmaitre florentmaitre force-pushed the 120-add-dimension-tokens-in-the-demo-app branch from 460097e to 550678d Compare November 8, 2024 14:06
@florentmaitre florentmaitre merged commit a8bb875 into develop Nov 8, 2024
9 checks passed
@florentmaitre florentmaitre deleted the 120-add-dimension-tokens-in-the-demo-app branch November 8, 2024 14:22
@florentmaitre florentmaitre mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentmaitre florentmaitre florentmaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dimension tokens in the demo app
2 participants
@paulinea @florentmaitre