-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 1.2.0 #849
Conversation
✅ Deploy Preview for ods-ios canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a une coquille dans le CHANGELOG (sur l'hyperlien de comparaison entre les dernières versions).
Je me demande s'il ne faut pas, si ce n'est pas déjà le cas, référencer toutes les images du dossier images dans le NOTICE.
CHANGELOG.md
Outdated
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased](https://github.com/Orange-OpenSource/ods-ios/compare/1.1.0...qualif) | |||
## [1.2.0](https://github.com/Orange-OpenSource/ods-ios/compare/1.0.0...1.2.0) - 2024-08-23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.1.0...1.2.0 plutôt non ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ? La remarque est valable pour tous les fichiers du dossier images en fait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.