Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 1.2.0 #849

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Prepare release 1.2.0 #849

merged 2 commits into from
Aug 23, 2024

Conversation

ludovic35
Copy link
Member

No description provided.

@ludovic35 ludovic35 requested a review from pylapp as a code owner August 23, 2024 08:44
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for ods-ios canceled.

Name Link
🔨 Latest commit 0ab3c1b
🔍 Latest deploy log https://app.netlify.com/sites/ods-ios/deploys/66c87b75a37cbf0008d605e2

Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a une coquille dans le CHANGELOG (sur l'hyperlien de comparaison entre les dernières versions).

Je me demande s'il ne faut pas, si ce n'est pas déjà le cas, référencer toutes les images du dossier images dans le NOTICE.

CHANGELOG.md Outdated
@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased](https://github.com/Orange-OpenSource/ods-ios/compare/1.1.0...qualif)
## [1.2.0](https://github.com/Orange-OpenSource/ods-ios/compare/1.0.0...1.2.0) - 2024-08-23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1.0...1.2.0 plutôt non ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ce fichier doit être listé dans le NOTICE comme une ressource étant sous licence propriétaire ? La remarque est valable pour tous les fichiers du dossier images en fait.

@ludovic35 ludovic35 requested a review from B3nz01d as a code owner August 23, 2024 12:07
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pylapp pylapp merged commit d151479 into qualif Aug 23, 2024
6 checks passed
@pylapp pylapp deleted the prepare-release branch August 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants