[#586] Update ListItem to limit title to one line and subtitle up to two lines #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for ods-ios canceled.
|
pylapp
changed the title
|
Sur le fonctionnel c'est bon. Toutefois je note un glitch concernant le bouton one line : quand il change d'état, on le voit très légèrement bouger à droite ou à gauche lorsque l'on sélectionne un autre bouton à côté. J'ai également une erreur en console qui apparait concernant le fichier Bagel-does-not-exist |
pylapp
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Quelques remarques anodines de forme, et deux points soulevés (dans ce commentaire #656 (comment))
OrangeDesignSystem/Sources/OrangeDesignSystem/Components/Lists/Internal/TrailingView.swift
Show resolved
Hide resolved
OrangeDesignSystemDemo/OrangeDesignSystemDemo/Resources/Base.lproj/Localizable.strings
Outdated
Show resolved
Hide resolved
pylapp
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.