Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#588] Voice Over focus order not consistent #649

Merged
merged 22 commits into from
Jan 31, 2024
Merged

[#588] Voice Over focus order not consistent #649

merged 22 commits into from
Jan 31, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Jan 29, 2024 •
edited
Loading

Issue

#588

Definition of Done

Documentation

  • Update CHANGELOG

Guidelines screen

  • Check and refactor Voice Over navigation for guidelines screen (fixed bcb1ab7)
  • Check and refactor Voice Over navigation for guidelines screen (colors) (fixed bcb1ab7)
  • Check and refactor Voice Over navigation for guidelines screen (typography) (fixed bcb1ab7)
  • Check and refactor Voice Over navigation for guidelines screen (spacings) (fixed bcb1ab7)

Components screen

  • Check and refactor Voice Over navigation for components screen (fixed b1ac263)
  • Check and refactor Voice Over navigation for components screen (banners) (fixed 5f868fd)
  • Check and refactor Voice Over navigation for components screen (nav bars) (fixed 9e90c6f)
  • Check and refactor Voice Over navigation for components screen (tabs) (fixed 1c48948)
  • Check and refactor Voice Over navigation for components screen (tool bar) (fixed 6ed4523)
  • Check and refactor Voice Over navigation for components screen (buttons) (fixed 7b71a0a)
  • Check and refactor Voice Over navigation for components screen (cards) (fixed e16b5c0)
  • Check and refactor Voice Over navigation for components screen (input fields) (fixed 263c39f)
  • Check and refactor Voice Over navigation for components screen (sliders) (fixed 573dbb8)
  • Check and refactor Voice Over navigation for components screen (progress bars) (fixed be50878)
  • Check and refactor Voice Over navigation for components screen (lists) (fixed 1cd6b0f)
  • Check and refactor Voice Over navigation for components screen (bottom pages) (fixed 743e7ae)
  • Check and refactor Voice Over navigation for components screen (chips) (fixed d6f5156)

Modules screen

  • Check and refactor Voice Over navigation for modules screen (fixed bc237b8)
  • Check and refactor Voice Over navigation for modules screen (lists) (fixed bc237b8)
  • Check and refactor Voice Over navigation for modules screen (about) (fixed bc237b8)
  • Check and refactor Voice Over navigation for modules screen (card collections) (fixed ed101b9)

About screen

  • Check and refactor Voice Over navigation for about screen (fixed 16f31d3)
  • Check and refactor Voice Over navigation for about screen (apps news) (fixed 6992faa)
  • Check and refactor Voice Over navigation for about screen (changelog)
  • Check and refactor Voice Over navigation for about screen (more apps)
  • Check and refactor Voice Over navigation for about screen (privacy policy)
  • Check and refactor Voice Over navigation for about screen (terms of service)
  • Check and refactor Voice Over navigation for about screen (accessibility statement)

@pylapp pylapp self-assigned this Jan 29, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner January 29, 2024 08:59
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

✅ Deploy Preview for ods-ios canceled.

Name Link
🔨 Latest commit 8b60548
🔍 Latest deploy log https://app.netlify.com/sites/ods-ios/deploys/65ba6688bcffb50008c6789e

@pylapp pylapp marked this pull request as draft January 29, 2024 08:59
@pylapp pylapp changed the title [#588] Vocie Over focus order not consistent [#588] Voice Over focus order not consistent Jan 29, 2024
@pylapp pylapp force-pushed the fix/588_Focus-Order-A11Y branch 5 times, most recently from 7b71a0a to d6f5156 Compare January 30, 2024 17:03
@pylapp
Copy link
Member Author

pylapp commented Jan 31, 2024 •
edited
Loading

Voice Over navigation for changelog item should be implemented later ; the HTML code produced based on Markdown file is not accessible enough, WKWebView chould be replaced by native component. Same thing for privacy policy and terms of uses.

pylapp added 19 commits January 31, 2024 15:34
@pylapp
chore(#588): a11y - update CHANGELOG
971d13b 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat(#588): a11y - view modifiers with a11y focus states and notif de…
3bc961d 
…lays

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - first item of components vocalized
d72b87c 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalization of title for each component page
f8139b3 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus on banner variants
ecf6f95 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus on nav bar variants
b54c953 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of tab bar
c4279bb 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of tool bar
e64db1c 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of buttons
42152d2 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of chips
f6200be 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of cards
598c7ba 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of text fields
1482cf5 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of sliders
a3fa865 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of progress indicators
5bf5642 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of lists
1a9ca40 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for variants of bottom sheets
9fe45ba 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for modules page and second-level p…
46e201e 
…ages

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - vocalized focus for cards demos pages
bea943e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix(#588): a11y - force VO focus to first vocalizable item in main pages
b06da03 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the fix/588_Focus-Order-A11Y branch from 6992faa to 50824ab Compare January 31, 2024 14:34
@pylapp pylapp marked this pull request as ready for review January 31, 2024 14:40
ludovic35
ludovic35 reviewed Jan 31, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- [SDK] Update ListItem to limit title in one line and subtitle up to two lines ([#586](https://github.com/Orange-OpenSource/ods-ios/issues/586))
- [DemoApp/SDK] Components page accessibility issues (Bug [#563](https://github.com/Orange-OpenSource/ods-ios/issues/563))
- [DemoApp/SDK] Code cleanup ([#647](https://github.com/Orange-OpenSource/ods-ios/issues/647)])
- [DemoApp/SDK] Focus order not coherent with Voice Over (Bug [#588](https://github.com/Orange-OpenSource/ods-ios/issues/588))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to first line

@pylapp pylapp linked an issue Jan 31, 2024 that may be closed by this pull request
[Bug]: [P1] Common accessibility issue - Focus order not coherent in components variants #588
Closed
1 task
pylapp added 2 commits January 31, 2024 16:19
@pylapp
refactor(#588): review - fix CHANGELOG
7395336 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: SwiftLint - add more rules
8b60548 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35 ludovic35 merged commit 5b75349 into qualif Jan 31, 2024
6 checks passed
@ludovic35 ludovic35 deleted the fix/588_Focus-Order-A11Y branch January 31, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 ludovic35 left review comments

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [P1] Common accessibility issue - Focus order not coherent in components variants
2 participants
@pylapp @ludovic35