Skip to content

Commit

Permalink
[P1] bug a11y module about title header (#828)
Browse files Browse the repository at this point in the history
* app : add accessibility header

* add changelog issues
  • Loading branch information
Tayebsed93 authored May 27, 2024
1 parent cd395b7 commit 8493377
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [DemoApp] A11y - Target size is too small for info and chevron components, difficult to tap without mistake. ([#732](https://github.com/Orange-OpenSource/ods-ios/issues/732))
- [DemoApp] A11y - Buttons component : group labels and buttons ([#760](https://github.com/Orange-OpenSource/ods-ios/issues/760))
- [DemoApp] A11y - Title is the same for both variants "Progress bar demo", title must be unique. ([#724](https://github.com/Orange-OpenSource/ods-ios/issues/724))
- [DemoApp] A11y - Buttons component : group labels and buttons ([#760](https://github.com/Orange-OpenSource/ods-ios/issues/760))
- [DemoApp/SDK] A11y - Module - About : Title header ([#827](https://github.com/Orange-OpenSource/ods-ios/issues/727))

## [1.1.0](https://github.com/Orange-OpenSource/ods-ios/compare/1.0.0...1.1.0) - 2024-03-08

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ public struct ODSFilterChipPicker<Value>: View where Value: Hashable {
VStack(alignment: .leading, spacing: ODSSpacing.s) {
title?
.odsFont(.headlineS)
.accessibilityAddTraits(.isHeader)
.frame(maxWidth: .infinity, alignment: .leading)
.padding(.horizontal, ODSSpacing.m)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ struct AboutSetup: View {
.odsFont(.headlineS)
.padding(.top, ODSSpacing.m)
.padding(.bottom, ODSSpacing.s)
.accessibilityAddTraits(.isHeader)

Text("screens.modules.about.mandatory")

Expand Down

0 comments on commit 8493377

Please sign in to comment.