Skip to content

Commit

Permalink
[P1] 760 a11y buttons component group labels and buttons (#824)
Browse files Browse the repository at this point in the history
* app : accessibility element group button component

* app : add changelog

* Update changelog

---------

Co-authored-by: Ludovic PINEL <[email protected]>
  • Loading branch information
Tayebsed93 and ludovic35 authored May 22, 2024
1 parent 5f7666b commit 239e19a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [Doc] Improve release documentation
- [Tooling] Define ZIP archive for nightly and production builds (for artifacts storage in CI/CD pipelines)

### Fixed

- [A11y] Buttons component : group labels and buttons ([#760](https://github.com/Orange-OpenSource/ods-ios/issues/760))

## [1.1.0](https://github.com/Orange-OpenSource/ods-ios/compare/1.0.0...1.1.0) - 2024-03-08

### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ struct EmphasisVariant: View {
.odsFont(.headlineS)
Spacer()
}
.accessibilityAddTraits(.isHeader)

ODSButton(text: Text(model.text),
image: model.icon,
Expand All @@ -52,6 +51,8 @@ struct EmphasisVariant: View {
.disabled(!model.showEnabled)
}
}
.accessibilityElement(children: .combine)
.accessibilityAddTraits(.isButton)
}
}

Expand Down

0 comments on commit 239e19a

Please sign in to comment.