Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSM: fix unintended scroll #364

Conversation

louismaximepiton
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Fixes #363.

Description

Remove unnecessary CSS for the embedded page

Motivation & Context

Remove useless scroll on the DSM page > Develop tab.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Checklist

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test on simulators and on a physical device (Android & iOS, orientation change, dark/light mode)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for ods-flutter ready!

Name Link
🔨 Latest commit 6d831eb
🔍 Latest deploy log https://app.netlify.com/sites/ods-flutter/deploys/660d25faf518ae0009057c88
😎 Deploy Preview https://deploy-preview-364--ods-flutter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the develop-lmp-fix-dsm-scroll branch from e86fe5a to 80f92c1 Compare March 28, 2024 14:23
@julien-deramond julien-deramond self-requested a review April 3, 2024 09:54
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've checked on Zeroheight staging and it fixes the issue.

2024-04-03 11 53 53

It can be backported to ODS Android and ODS iOS the same way.

@Tayebsed93 Tayebsed93 merged commit ed743a7 into Orange-OpenSource:develop Apr 3, 2024
7 checks passed
@louismaximepiton louismaximepiton deleted the develop-lmp-fix-dsm-scroll branch April 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Embedded pages in ZeroHeight can contain a vertical scroll bar
3 participants