Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(web): add kIsWeb before Platform calls #359

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Thelm76
Copy link
Contributor

@Thelm76 Thelm76 commented Mar 15, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

None found

Description

adding checks "kIsWeb" before calling Plateform methods

Motivation & Context

Plateform is not supported by flutter web, so each time it is called, we must ensure that we are not in a web environment using kIsWeb

Types of change

  • Bug fix (non-breaking which fixes an issue)

Checklist

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test on simulators and on a physical device (Android & iOS, orientation change, dark/light mode)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for ods-flutter ready!

Name Link
🔨 Latest commit 33bb75d
🔍 Latest deploy log https://app.netlify.com/sites/ods-flutter/deploys/660c0d3504a0d90008b8dc3b
😎 Deploy Preview https://deploy-preview-359--ods-flutter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tayebsed93 Tayebsed93 self-assigned this Apr 2, 2024
@Tayebsed93 Tayebsed93 merged commit 4bdc6e5 into Orange-OpenSource:develop Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants