Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 refactor(l10n): improve readability #353

Closed

Conversation

Thelm76
Copy link
Contributor

@Thelm76 Thelm76 commented Mar 13, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Add an extension on context to lighten AppLocalization call syntax

Motivation & Context

this improves readability and optimizes the applocalization calls by only using the "of" once per build method

Types of change

  • Refactoring (non-breaking change)

Checklist

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with responsive display

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test on simulators and on a physical device (Android & iOS, orientation change, dark/light mode)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for ods-flutter canceled.

Name Link
🔨 Latest commit 06dfb0d
🔍 Latest deploy log https://app.netlify.com/sites/ods-flutter/deploys/660c1f061edd65000857a220

@Thelm76 Thelm76 force-pushed the refactor/localization_gestion branch from a25a2a9 to 027cc19 Compare March 18, 2024 10:43
Mateo MARTINEZ and others added 3 commits April 2, 2024 16:36
# Conflicts:
#	app/lib/ui/components/cards/card_vertical_header_first.dart
#	app/lib/ui/components/chips/chips_action.dart
#	app/lib/ui/components/textfields/textfield.dart
#	app/lib/ui/components/textfields/textfield_password.dart
#	app/lib/ui/theme/theme_selector.dart
@Tayebsed93 Tayebsed93 force-pushed the refactor/localization_gestion branch from 29d394c to 2372ca0 Compare April 2, 2024 14:40
@Tayebsed93 Tayebsed93 self-assigned this Apr 2, 2024
@Tayebsed93 Tayebsed93 closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants