Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Embedded pages in ZeroHeight can contain a vertical scroll bar #363

Closed
1 task done
julien-deramond opened this issue Mar 28, 2024 · 0 comments · Fixed by #364
Closed
1 task done

[Bug]: Embedded pages in ZeroHeight can contain a vertical scroll bar #363

julien-deramond opened this issue Mar 28, 2024 · 0 comments · Fixed by #364
Assignees
Labels
🐞 bug Something isn't working 📖 documentation Improvements or additions to documentation 👌 OK PO

Comments

@julien-deramond
Copy link
Member

julien-deramond commented Mar 28, 2024

Prerequisites

Describe the issue

When a user goes to the Develop tab of https://system.design.orange.com/0c1af118d/p/0326f8-navigation-rails/b/39a3e0 and reads the page, the embedded content is scrollable and shouldn't:

2024-03-28 07 07 43

This seems to be caused by the following style in detail.html or main.html (I don't remember which one is used for the embedded version):

html, body {
  min-height: 100vh;
}

This is to be tested in a ZeroHeight staging environment, but I'd say it's safe to remove only for the layout in "embedded mode" (pages without the _docs suffix in the URL; e.g. https://orange-opensource.github.io/ods-flutter/components/navigation_rail)

⚠️ Once it's patched in ODS Flutter, the same patch should be applied to ODS Android and ODS iOS. Linked tasks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📖 documentation Improvements or additions to documentation 👌 OK PO
Development

Successfully merging a pull request may close this issue.

3 participants