Skip to content

Commit

Permalink
343 bug accessibility add a header to the large title (#344)
Browse files Browse the repository at this point in the history
* library : add vocalisation large top app header

* app and library : add changelog
  • Loading branch information
Tayebsed93 authored Mar 6, 2024
1 parent d1dab1f commit dad86ef
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions app/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [Bug]: Icons Button name ([#334](https://github.com/Orange-OpenSource/ods-flutter/issues/334))
- [Bug]: - Navigation Rail : Name customization ([#333](https://github.com/Orange-OpenSource/ods-flutter/issues/333))
- [Bug]: Card buttons ([#329](https://github.com/Orange-OpenSource/ods-flutter/issues/329))
- [Bug]: Accessibility - add a header to the large title ([#343](https://github.com/Orange-OpenSource/ods-flutter/issues/343))

### [0.7.O](https://github.com/Orange-OpenSource/ods-flutter/compare/0.1.1...0.7.0) - 2023-02-02

Expand Down
1 change: 1 addition & 0 deletions library/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [Bug]: Icons Button name ([#334](https://github.com/Orange-OpenSource/ods-flutter/issues/334))
- [Bug]: - Navigation Rail : Name customization ([#333](https://github.com/Orange-OpenSource/ods-flutter/issues/333))
- [Bug]: Card buttons ([#329](https://github.com/Orange-OpenSource/ods-flutter/issues/329))
- [Bug]: Accessibility - add a header to the large title ([#343](https://github.com/Orange-OpenSource/ods-flutter/issues/343))

## [0.7.0](https://github.com/Orange-OpenSource/ods-flutter/compare/0.1.1...0.7.0) - 2023-02-02

Expand Down
13 changes: 8 additions & 5 deletions library/lib/components/app_bar/top/ods_large_top_app_bar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,14 @@ class OdsLargeTopAppBar extends StatelessWidget implements PreferredSizeWidget {
Widget build(BuildContext context) {
return CustomScrollView(
slivers: <Widget>[
SliverAppBar.large(
title: Text(title),
actions: actions,
leading: navigationIcon,
automaticallyImplyLeading: navigationIcon != null ? true : false,
Semantics(
header: true,
child: SliverAppBar.large(
title: Text(title),
actions: actions,
leading: navigationIcon,
automaticallyImplyLeading: navigationIcon != null ? true : false,
),
),

/// Adding a list as content
Expand Down

0 comments on commit dad86ef

Please sign in to comment.