Skip to content

Commit

Permalink
334 bug icons button name (#336)
Browse files Browse the repository at this point in the history
* app : fix name icons buttons and fix order variant

* app and library : add changelog
  • Loading branch information
Tayebsed93 authored Feb 28, 2024
1 parent 0b3f474 commit 46086f4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions app/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Update components to show label content examples ([#198](https://github.com/Orange-OpenSource/ods-flutter/issues/295))
- [Bug]: Text Field > Trailing element > text issue ([#314](https://github.com/Orange-OpenSource/ods-flutter/issues/314))
- [Bug]: Text Field > Input type > single line doesn't stay on 1 line ([#315](https://github.com/Orange-OpenSource/ods-flutter/issues/315))
- [Bug]: Icons Button name ([#334](https://github.com/Orange-OpenSource/ods-flutter/issues/334))

### [0.7.O](https://github.com/Orange-OpenSource/ods-flutter/compare/0.1.1...0.7.0) - 2023-02-02

Expand Down
2 changes: 1 addition & 1 deletion app/lib/l10n/ods_flutter_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"segmentedButtonsVariantSubtitle": "OdsSegmentedButton",
"segmentedEnumSingle": "Single",
"segmentedEnumMulti": "Multi",
"buttonsIconVariantTitle": "Buttons Icons",
"buttonsIconVariantTitle": "Icons Button",
"buttonsIconVariantSubtitle": "OdsButtonIcon",
"buttonsIconFunctionalStandardEnum": "Standard",
"buttonsIconFunctionalFilledEnum": "Filled",
Expand Down
8 changes: 4 additions & 4 deletions app/lib/ui/components/components.dart
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@ List<Component> components(BuildContext context) {
AppLocalizations.of(context)!.buttonsFunctionalVariantTitle,
AppLocalizations.of(context)!.buttonsFunctionalVariantSubtitle,
ButtonsContained(emphasis: ButtonEmphasis.functional)),
Variant(
AppLocalizations.of(context)!.segmentedButtonsVariantTitle,
AppLocalizations.of(context)!.segmentedButtonsVariantSubtitle,
SegmentedButtons()),
Variant(
AppLocalizations.of(context)!.buttonsIconVariantTitle,
AppLocalizations.of(context)!.buttonsIconVariantSubtitle,
ButtonsIcons()),
Variant(
AppLocalizations.of(context)!.segmentedButtonsVariantTitle,
AppLocalizations.of(context)!.segmentedButtonsVariantSubtitle,
SegmentedButtons()),
],
),
Component(
Expand Down
1 change: 1 addition & 0 deletions library/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [Bug]: Snackbar without action text positioning ([#198](https://github.com/Orange-OpenSource/ods-flutter/issues/198))
- [Bug]: Text Field > Trailing element > text issue ([#314](https://github.com/Orange-OpenSource/ods-flutter/issues/314))
- [Bug]: Text Field > Input type > single line doesn't stay on 1 line ([#315](https://github.com/Orange-OpenSource/ods-flutter/issues/315))
- [Bug]: Icons Button name ([#334](https://github.com/Orange-OpenSource/ods-flutter/issues/334))

## [0.7.0](https://github.com/Orange-OpenSource/ods-flutter/compare/0.1.1...0.7.0) - 2023-02-02

Expand Down

0 comments on commit 46086f4

Please sign in to comment.