Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

[DRAFT] add ability to override default authorizers.xml template #170

Closed
wants to merge 2 commits into from
Closed

[DRAFT] add ability to override default authorizers.xml template #170

wants to merge 2 commits into from

Conversation

mh013370
Copy link
Contributor

@mh013370 mh013370 commented Dec 6, 2021

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #169
License Apache 2.0

What's in this PR?

This is an attempt at adding support for overriding the default authorizer configuration. I've put this in [DRAFT] status until the approach is given a 👍 , @erdrix .

Adds ReadOnlyConfig.AuthorizerConfig with two properties:

  • ReplaceTemplateConfigMap
  • ReplaceTemplateSecretConfig

These are ConfigMap or Secret refs to override the default authorizers.xml template. The docs clarify this, but the order of precedence follows similar conventions for other configurations:

Secret > ConfigMap > default

The purpose of this PR is to configure a custom authorizer, userGroupProvider, and accessPolicyProvider.

Why?

It's not possible to configure an authorizer other than managed-authorizer or userGroupProvider/accessPolicyProvider other than the file-based ones.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

To Do

  • get 👍 on approach

@mh013370 mh013370 changed the title [DRAFT] add ability to override default template authorizers.xml [DRAFT] add ability to override default authorizers.xml template Dec 6, 2021
mh013370 added 2 commits March 3, 2022 16:01
fix wrong text

Signed-off-by: Michael H <[email protected]>

update changelog

Signed-off-by: Michael H <[email protected]>
Signed-off-by: Michael H <[email protected]>
@mh013370 mh013370 closed this by deleting the head repository Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to override/replace authorizers.xml template
1 participant