feat(helm): init helm chart #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydoomfr
force-pushed
the
feat-helmchart
branch
from
630dfda to
e4bb886
Compare
mydoomfr
force-pushed
the
feat-helmchart
branch
2 times, most recently
from
c8568eb to
35367df
Compare
Signed-off-by: PINCHON Benjamin <[email protected]>
mydoomfr
force-pushed
the
feat-helmchart
branch
from
35367df to
4274774
Compare
antrema
requested changes
Oct 30, 2024
| Determine the image to use | ||
| */}} | ||
| {{- define "powerdns-operator.image" -}} | ||
| {{ printf "%s:v%s" .image.repository (.image.tag | default .chartAppVersion) }} |
There was a problem hiding this comment.
Why not:
{{ printf "%s:v%s" .Values.image.repository (.Values.image.tag | default .Chart.AppVersion) }}
| - main | ||
| - release-* | ||
| paths: | ||
| - charts/powerdns-operator/Chart.yaml |
There was a problem hiding this comment.
Separate 'lint-and-test' on all commits and 'release' on charts/powerdns-operator/Chart.yaml evolutions
| - name: Configure Git | ||
| run: | | ||
| git config user.name "$GITHUB_ACTOR" | ||
| git config user.email "[email protected]" |
| - name: Configure Git | ||
| run: | | ||
| git config user.name "$GITHUB_ACTOR" | ||
| git config user.email "[email protected]" |
| - name: Install chart unittest | ||
| run: | | ||
| helm env | ||
| helm plugin install https://github.com/helm-unittest/helm-unittest |
|
Helm chart treated in a separate project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.