Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add catalog specification for Zone #14

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

antrema
Copy link
Collaborator

@antrema antrema commented Sep 11, 2024

  • Add Catalog specification in Zone
  • Add associated tests

@antrema antrema requested a review from mydoomfr September 11, 2024 14:53
@antrema antrema self-assigned this Sep 11, 2024
@antrema antrema force-pushed the add-catalog branch 3 times, most recently from 486e2ac to 10e0f55 Compare September 11, 2024 15:58
internal/controller/suite_test.go Outdated Show resolved Hide resolved
internal/controller/zone_controller.go Show resolved Hide resolved
internal/controller/zone_controller_test.go Outdated Show resolved Hide resolved
internal/controller/zone_controller_test.go Show resolved Hide resolved
Copy link
Contributor

@mydoomfr mydoomfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antrema antrema merged commit 8fe6410 into Orange-OpenSource:main Sep 12, 2024
6 checks passed
@antrema antrema deleted the add-catalog branch September 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants