-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OUDS] Add "Font" tokens, utilities and documentation #2774
Conversation
eec9a1b
to
2f78431
Compare
44b051b
to
14eff8e
Compare
2f78431
to
a378e58
Compare
3645f63
to
654deeb
Compare
33dc6ce
to
fdab9a8
Compare
c2f3283
to
c45da13
Compare
f0847dd
to
5671e80
Compare
48363d8
to
2038898
Compare
b2395b9
to
78a4d04
Compare
78a4d04
to
665c7a2
Compare
665c7a2
to
6425606
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
------------ Co-authored-by: Hannah Issermann <[email protected]>
…of migration guide from Boosted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the following is missing in our migration guides:
- The import stack for our helper changed a bit to include
helpers/icon
(maybe only the from Boosted one) - I think we can maybe introduce the new mixin
ouds-font-size($name)
to people and maybe a link to redirect to{{< docsref "/content/typography#sass-mixins" >}}
if people want to dig into it a bit more.
…ouds/main-lmp-tokens-font
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all discussions, LGTM 😄
Related issues
Closes #2645.
Description
Remaining tasks and questions
Questions:
Tasks:
Done list
The following was done in the PR:
.display-*
class name..initialism
.blockquotes
. Should be invisible from user point of view..mw-none
.rem
spacings for font by somepx
ones.generate-utility
mixin.To be done after the PR is merged
generate-utility
should take several mixins into account.reboot.md
should be updated once the Link component is developed.reboot.md
should be updated once the colors have been developed.reboot.md
should be updated once the List component is developed.typography.md
should be updated once the List component is developed.typography.md
should be updated once the Link component is developed.typography.md
should be updated once the colors have been developed.icon.md
should be updated once the icons page have been developed.text.md
should be updated once the colors have been developed.Motivation & Context
Types of change
Live previews