Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Add "Font" tokens, utilities and documentation #2774

Merged
merged 31 commits into from
Nov 28, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 23, 2024

Related issues

Closes #2645.

Description

Remaining tasks and questions

Questions:

  • .

Tasks:

  • .

Done list

The following was done in the PR:

  • Introduced new Sass maps, mixin and variables.
  • Introduced new CSS vars.
  • Easier heading and overall font declaration (Looks almost like the Bootstrap one now).
  • Tweaked the .display-* class name.
  • Removed .initialism.
  • Small changes for blockquotes. Should be invisible from user point of view.
  • Added a .mw-none.
  • Adapted utilities to OUDS ones.
  • Changed the rem spacings for font by some px ones.
  • Adapted the font family stack.
  • Adapted all the Bootstrap variables to use OUDS tokens.
  • Added a new icon helper.
  • Tweaked a bit the generate-utility mixin.
  • Add tests for font utilities.
  • Separate grid and font tests.
  • Added according documentation.
  • Added an example to see the fonts live.

To be done after the PR is merged

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

@louismaximepiton louismaximepiton added feature docs Improvements or additions to documentation css labels Oct 23, 2024
@louismaximepiton louismaximepiton added this to the OUDS milestone Oct 23, 2024
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-spacing branch from eec9a1b to 2f78431 Compare October 23, 2024 10:28
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch from 44b051b to 14eff8e Compare October 23, 2024 10:28
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-spacing branch from 2f78431 to a378e58 Compare October 23, 2024 13:49
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch 2 times, most recently from 3645f63 to 654deeb Compare October 23, 2024 14:47
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-spacing branch 3 times, most recently from 33dc6ce to fdab9a8 Compare October 25, 2024 08:02
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch 2 times, most recently from c2f3283 to c45da13 Compare October 28, 2024 16:06
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-spacing branch from f0847dd to 5671e80 Compare October 29, 2024 07:24
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch 5 times, most recently from 48363d8 to 2038898 Compare October 31, 2024 09:07
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch 2 times, most recently from b2395b9 to 78a4d04 Compare November 8, 2024 15:36
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch from 78a4d04 to 665c7a2 Compare November 12, 2024 11:40
Base automatically changed from ouds/main-lmp-tokens-spacing to ouds/main November 12, 2024 13:59
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-tokens-font branch from 665c7a2 to 6425606 Compare November 12, 2024 14:30
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 17917f9
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/674749dd9dbdf60008a1379f
😎 Deploy Preview https://deploy-preview-2774--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration.md Show resolved Hide resolved
site/content/docs/0.0/content/reboot.md Outdated Show resolved Hide resolved
site/content/docs/0.0/content/typography.md Outdated Show resolved Hide resolved
scss/_type.scss Show resolved Hide resolved
scss/_maps.scss Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
scss/_type.scss Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
scss/_maps.scss Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
Copy link
Member Author

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the following is missing in our migration guides:

  • The import stack for our helper changed a bit to include helpers/icon (maybe only the from Boosted one)
  • I think we can maybe introduce the new mixin ouds-font-size($name) to people and maybe a link to redirect to {{< docsref "/content/typography#sass-mixins" >}} if people want to dig into it a bit more.

site/content/docs/0.0/migration.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
site/content/docs/0.0/migration-from-boosted.md Outdated Show resolved Hide resolved
scss/_variables.scss Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
site/content/docs/0.0/helpers/icon.md Outdated Show resolved Hide resolved
Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all discussions, LGTM 😄

@louismaximepiton louismaximepiton merged commit 30e7344 into ouds/main Nov 28, 2024
15 checks passed
@louismaximepiton louismaximepiton deleted the ouds/main-lmp-tokens-font branch November 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation feature
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants