chore: update tokens #2766
Closed
chore: update tokens #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Pushed 3f90b98 to:
|
louismaximepiton
requested changes
Oct 22, 2024
| $ouds-border-radius-9999: 2000px !default; | ||
| $ouds-border-style-dashed: "dashed" !default; |
There was a problem hiding this comment.
This doesn't work anymore, see: https://deploy-preview-2766--boosted.netlify.app/docs/0.0/utilities/borders/#drag-and-drop
| $ouds-border-style-dashed: "dashed" !default; | ||
| // $ouds-border-style-dotted: "dotted" !default; | ||
| // $ouds-border-style-none: "none" !default; | ||
| $ouds-border-style-solid: "solid" !default; |
There was a problem hiding this comment.
Same here I think, it's just the default so it looks good for now.
| // $ouds-border-style-dotted: "dotted" !default; | ||
| // $ouds-border-style-none: "none" !default; | ||
| $ouds-border-style-solid: "solid" !default; | ||
| $ouds-border-radius-0: $ouds-border-base * 0 !default; // 0 |
There was a problem hiding this comment.
Suggested change
| $ouds-border-radius-0: $ouds-border-base * 0 !default; // 0 | |
| $ouds-border-radius-0: strip-units($ouds-border-base * 0) !default; // 0 |
Is there any way to do it on Tokenator side ? I mean when it's * 0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is generated automatically, it updates the tokens based on Figma Variables.