Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] chore(merge main): patched Boosted commit → 9518929 #2738

Merged
merged 10 commits into from
Sep 18, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 17, 2024

Description

This PR gathers Boosted commits from 0ae070a to 9518929, excluding the ones coming from Bootstrap, as they will be handled by #2595.

@julien-deramond julien-deramond added this to the OUDS milestone Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d79d761
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66eac24e12c0d90008b1ec75
😎 Deploy Preview https://deploy-preview-2738--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review September 17, 2024 10:58
@julien-deramond julien-deramond changed the title [OUDS] chore(merge main): patched Boosted commit → 6799663 [OUDS] chore(merge main): patched Boosted commit → 9518929 Sep 17, 2024
Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, if you're ok for the accessibility guidelines link in English

@julien-deramond
Copy link
Member Author

Looks fine, if you're ok for the accessibility guidelines link in English

I'm fine with the change. Even if we would like to change it, it must be done first in main, and then via another ouds/main patched Boosted commit kind of PR.

@julien-deramond julien-deramond merged commit 34f6946 into ouds/main Sep 18, 2024
12 checks passed
@julien-deramond julien-deramond deleted the ouds/main-jd-chore-merge-from-0ae070a branch September 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants