Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit: All texts must be included in a semantic tag (design callouts) #2722

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Sep 6, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2667 issue 1-2

Description

Change the <div> with a semantic <p> tag, so that the text and link of the design callouts is included into something. No visual change.

Motivation & Context

Accessibility issue from the audit, see #2667

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 078b3b9
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66dad07bb22f2f0008b3a560
😎 Deploy Preview https://deploy-preview-2722--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@hannahiss hannahiss changed the title Fix a11y audit: All texts must be included in a semantic tag Fix a11y audit: All texts must be included in a semantic tag (design callouts) Sep 6, 2024
@hannahiss hannahiss marked this pull request as ready for review September 6, 2024 13:37
@julien-deramond julien-deramond self-requested a review September 9, 2024 11:51
@julien-deramond julien-deramond merged commit 0ae070a into main Sep 9, 2024
21 checks passed
@julien-deramond julien-deramond deleted the main-his-a11y-1-2-missing-p branch September 9, 2024 11:52
This was referenced Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants