Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Docs review after first OUDS version (including opacity tokens) #2713

Merged
merged 21 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ca59704
OUDS doc review - issue 2589
hannahiss Sep 2, 2024
bcaa82f
OUDS doc review - issue 2589
hannahiss Sep 4, 2024
335fbf7
OUDS doc review - issue 2589
hannahiss Sep 4, 2024
36b0d5d
OUDS doc review - issue 2589
hannahiss Sep 4, 2024
ad71ace
OUDS doc review - revert dist
hannahiss Sep 4, 2024
758fbba
Update site/content/docs/0.0/customize/options.md
hannahiss Sep 6, 2024
dc05ead
Uncomment utilities since we do have some utilities now
hannahiss Sep 6, 2024
a3e2635
Merge branch 'ouds/main' into ouds/main-his-2589-review
hannahiss Sep 6, 2024
6eb0e05
Uncomment $enable-important-utilities
hannahiss Sep 6, 2024
b42d302
Remove blank line
hannahiss Sep 9, 2024
48d0bd4
Rollback wcag version since this fix will come from Bootstrap and Boo…
hannahiss Sep 9, 2024
980c857
Rollback hide example d-print-block not to forget it later
hannahiss Sep 9, 2024
87a441e
Rollback accessible names of license links (done in PR #2723 on main …
hannahiss Sep 9, 2024
042f3dd
Add info about Bootstrap compatibility and tokens
hannahiss Sep 17, 2024
03f93a5
Merge branch 'ouds/main' into ouds/main-his-2589-review
hannahiss Sep 17, 2024
01acc1d
Merge branch 'ouds/main' into ouds/main-his-2589-review
hannahiss Sep 19, 2024
12535a6
fixes after Julien's review
hannahiss Sep 20, 2024
e6db139
remove word "tokens"
hannahiss Sep 20, 2024
85ca61a
Minor modifications
julien-deramond Sep 23, 2024
a5dc283
Add link to bootstrap compatibility paragraph in migration from Boost…
hannahiss Sep 23, 2024
fd14bdf
remove link to bootstrap compatibility paragraph inside details>summary
hannahiss Sep 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/content/docs/0.0/about/license.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ OUDS Web is released under the MIT license and is copyright {{< year >}} Orange
- Include the source of OUDS Web nor Bootstrap itself, or of any modifications you may have made to it, in any redistribution you may assemble that includes it
- Submit changes that you make to OUDS Web or Bootstrap back to their respective project (though such feedback is encouraged)

For more information, the full OUDS Web license is located [in the project repository]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/LICENSE), and Bootstrap license is located [in the project repository](https://github.com/twbs/bootstrap/blob/v{{< param bootstrap_current_version >}}/LICENSE).
For more information, the [full OUDS Web license is located in the project repository]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/LICENSE), and [Bootstrap license is located in the project repository](https://github.com/twbs/bootstrap/blob/v{{< param bootstrap_current_version >}}/LICENSE).
hannahiss marked this conversation as resolved.
Show resolved Hide resolved
12 changes: 6 additions & 6 deletions site/content/docs/0.0/customize/custom-libraries.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,19 @@ toc: true
**This content is not intended for standalone projects.** It is specifically for those looking to customize the entire library to fit a completely different design or brand.
{{< /callout >}}

## Architecture
## Tokens architecture

### Raw tokens

The [`scss/tokens/_raw.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_raw.scss) file consolidates all basic tokens. While these tokens don't carry semantic meaning and aren't meant to be used directly, they form the foundation of the Orange Unified Design System. Their primary purpose is to be utilized by semantic tokens, and occasionally, by component tokens.
The [`scss/tokens/_raw.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_raw.scss) file consolidates all basic tokens. While these tokens don't carry semantic meaning and aren't meant to be used directly in projects, they form the foundation of the Orange Unified Design System. Their primary purpose is to be utilized by semantic tokens, and occasionally, by component tokens.

### Semantic tokens

The [`scss/tokens/_semantic.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_semantic.scss) file contains all the semantic tokens. Unlike raw tokens, these are intended to be used directly. They are built on raw tokens, assigning them semantic meaning through media queries or specific contexts. These tokens are ready to be applied either in utilities or directly within component tokens.
The [`scss/tokens/_semantic.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_semantic.scss) file contains all the semantic tokens. Unlike raw tokens, these are intended to be used directly in projects. They are built on raw tokens, assigning them semantic meaning through media queries or specific contexts. These tokens are ready to be applied either in utilities or directly within component tokens.

### Component tokens

The [`scss/tokens/_component.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_component.scss) file is dedicated to component tokens. These tokens should be used exclusively within components, often relying on semantic tokens, though they may occasionally reference raw tokens. Essentially, they map the semantic tokens to components.
The [`scss/tokens/_component.scss`]({{< param repo >}}/blob/v{{< param current_version >}}-ouds-web/scss/tokens/_component.scss) file is dedicated to component tokens. These tokens could be used in projects, but exclusively within components, often relying on semantic tokens, though they may occasionally reference raw tokens. Essentially, they map the semantic tokens to components.

## Customization

Expand All @@ -34,11 +34,11 @@ The [`scss/tokens/_component.scss`]({{< param repo >}}/blob/v{{< param current_v

If you have a designer (which is highly recommended when creating a new brand), implementing changes should be straightforward. You'll need to replace our token files with those provided by your designer, manually substituting and remapping tokens to match your brand’s specifications.

For a practical example of how this process works and what your customized library should look like after the changes, refer to [our guide on Stackblitz](https://stackblitz.com/edit/github-j5teen).
For a practical example of how this process works and what your customized library should look like after the changes, refer to [our example on Stackblitz](https://stackblitz.com/edit/github-j5teen).

#### Having no designer

In the absence of a designer, it’s advisable to reach out to the [OUDS Web core team]({{< docsref "/about/team" >}}).
In the absence of a designer, it’s advisable to reach out to the [OUDS Web core team]({{< docsref "/about/team" >}}) for support.

### Building and deploying documentation

Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/0.0/customize/options.md
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ You can find and customize these variables for key global options in OUDS Web's
| Variable | Values | Description |
| --------------------------------- | ------------------------------------- | -------------------------------------------------------------------------------------- |
| `$enable-bootstrap-compatibility` | `true` or `false` (default) | Enforces Bootstrap compatibility. |
| `$enable-grid-classes` | `true` (default) or `false` | Enables the generation of CSS classes for the grid system (e.g. `.row`, `.col-md-1`, etc.). |
hannahiss marked this conversation as resolved.
Show resolved Hide resolved
<!--| `$spacer` | `1.25rem` (default), or any value > 0 | Specifies the default spacer value to programmatically generate our [spacer utilities]({{< docsref "/utilities/spacing" >}}). |
| `$enable-dark-mode` | `true` (default) or `false` | Enables built-in [dark mode support]({{< docsref "/customize/color-modes#dark-mode" >}}) across the project and its components. |
| `$enable-rounded` | `true` or `false` (default) | Enables predefined `border-radius` styles on various components. |
| `$enable-shadows` | `true` or `false` (default) | Enables predefined decorative `box-shadow` styles on various components. Does not affect `box-shadow`s used for focus states. |
| `$enable-gradients` | `true` or `false` (default) | Enables predefined gradients via `background-image` styles on various components. |
| `$enable-transitions` | `true` (default) or `false` | Enables predefined `transition`s on various components. |
| `$enable-reduced-motion` | `true` (default) or `false` | Enables the [`prefers-reduced-motion` media query]({{< docsref "/getting-started/accessibility#reduced-motion" >}}), which suppresses certain animations/transitions based on the users' browser/operating system preferences. |
| `$enable-grid-classes` | `true` (default) or `false` | Enables the generation of CSS classes for the grid system (e.g. `.row`, `.col-md-1`, etc.). |
| `$enable-container-classes` | `true` (default) or `false` | Enables the generation of CSS classes for layout containers. (New in v5.2.0) |
| `$enable-caret` | `true` (default) or `false` | Enables pseudo element caret on `.dropdown-toggle`. |
| `$enable-button-pointers` | `true` (default) or `false` | Add "hand" cursor to non-disabled button elements. |
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/0.0/getting-started/accessibility.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ OUDS Web provides an easy-to-use framework of ready-made styles, layout tools, a

## Overview and limitations

The overall accessibility of any project built with OUDS Web depends in large part on the author's markup, additional styling, and scripting they've included. However, provided that these have been implemented correctly, it should be perfectly possible to create websites and applications with OUDS Web that fulfill [<abbr title="Web Content Accessibility Guidelines">WCAG</abbr> 2.1](https://www.w3.org/TR/WCAG/) (A/AA/AAA), [Section 508](https://www.section508.gov/), and similar accessibility standards and requirements.
The overall accessibility of any project built with OUDS Web depends in large part on the author's markup, additional styling, and scripting they've included. However, provided that these have been implemented correctly, it should be perfectly possible to create websites and applications with OUDS Web that fulfill [<abbr title="Web Content Accessibility Guidelines">WCAG</abbr> 2.2](https://www.w3.org/TR/WCAG/) (A/AA/AAA), [Section 508](https://www.section508.gov/), and similar accessibility standards and requirements.
hannahiss marked this conversation as resolved.
Show resolved Hide resolved

### Structural markup

Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/0.0/getting-started/contents.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ OUDS Web includes a handful of options for including some or all of our compiled
{{< bs-table "table" >}}
| CSS files | Layout | Content | Components | Utilities |
| --- | --- | --- | --- | --- |
| `ouds-web.css`<br> `ouds-web.min.css`<br> `ouds-web.rtl.css`<br> `ouds-web.rtl.min.css` | Included | Included | Included | Included |
| `ouds-web-bootstrap.css`<br> `ouds-web-bootstrap.min.css`<br> `ouds-web-bootstrap.rtl.css`<br> `ouds-web-bootstrap.rtl.min.css` | Included | Included | Included | Included (with Bootstrap utilities) |
| `ouds-web.css`<br> `ouds-web.min.css`<br> `ouds-web.rtl.css`<br> `ouds-web.rtl.min.css` | Included | Included | Included | Included without Bootstrap utilities |
| `ouds-web-bootstrap.css`<br> `ouds-web-bootstrap.min.css`<br> `ouds-web-bootstrap.rtl.css`<br> `ouds-web-bootstrap.rtl.min.css` | Included | Included | Included | Included with Bootstrap utilities |
| `ouds-web-grid.css`<br> `ouds-web-grid.rtl.css`<br> `ouds-web-grid.min.css`<br> `ouds-web-grid.rtl.min.css` | <!--[Only grid system]({{< docsref "/layout/grid" >}})-->— | — | — | [Only flex utilities]({{< docsref "/utilities/flex" >}}) |
| `ouds-web-utilities.css`<br> `ouds-web-utilities.rtl.css`<br> `ouds-web-utilities.min.css`<br> `ouds-web-utilities.rtl.min.css` | — | — | — | Included |
| `ouds-web-reboot.css`<br> `ouds-web-reboot.rtl.css`<br> `ouds-web-reboot.min.css`<br> `ouds-web-reboot.rtl.min.css` | — | <!--[Only Reboot]({{< docsref "/content/reboot" >}})-->— | — | — |
Expand Down
5 changes: 3 additions & 2 deletions site/content/docs/0.0/migration.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file and the Boosted migration, we often say:

"[...] only available when $enable-bootstrap-compatibility is on"

Could be a link to the new content at /docs/extend/approach/#bootstrap-compatibility

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modification @hannahiss
Maybe it should be done in the "migration-from-boosted.md" too when we say "You can still have them using $enable-bootstrap-compatibility.".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Maybe we should also move the paragraph "from now on, ..." up in the text, so everyone sees it at the beginning of the migration guide

Copy link
Member

@julien-deramond julien-deramond Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file (migration.md), it's a migration version per version. When we'll release the first real versions, we'll change the content of this file, and yeah, we should put it at the beginning of the migration guide.
For now, IMO, it's OK as is.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ toc: true

### Pre-compiled versions

From now on, OUDS Web won't embed Bootstrap elements that are not part of Orange Unified Design System. However, you can still use our Bootstrap compatibility mode by using `ouds-web-bootstrap.css` and `ouds-web-bootstrap.min.css`.
From now on, by default, OUDS Web won’t embed Bootstrap helpers and utilities that do not comply with Orange Unified Design System. However, you can still use our Bootstrap compatibility mode by using `ouds-web-bootstrap.css` and `ouds-web-bootstrap.min.css`.
julien-deramond marked this conversation as resolved.
Show resolved Hide resolved

julien-deramond marked this conversation as resolved.
Show resolved Hide resolved

### Utilities

Expand All @@ -24,7 +25,7 @@ From now on, OUDS Web won't embed Bootstrap elements that are not part of Orange
### CSS and Sass variables

- <span class="badge text-bg-success">New</span> `$enable-bootstrap-compatibility` option set to `false` by default. This option allows you to compile the Sass files with a Bootstrap compatibility mode.
- For instance, without the Bootstrap compatibility mode, you won't have the opacity Bootstrap utilities such as `opacity-0`, `opacity-1`, `opacity-50`, etc. You will only have the semantic OUDS Web utilities such as `opacity-transparent`, `opacity-weaker`, `opacity-weak`, etc.
- For instance, without the Bootstrap compatibility mode, you won't have the opacity Bootstrap utilities such as `opacity-0`, `opacity-1`, `opacity-50`, etc. You will only have the OUDS Web utilities such as `opacity-transparent`, `opacity-weaker`, `opacity-weak`, etc.

- <span class="badge text-bg-success">New</span> OUDS Web fully implements the design tokens. If you were using the Sass compilation, you must import the new Sass files before the variables.

Expand Down
3 changes: 2 additions & 1 deletion site/content/docs/0.0/utilities/display.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,10 @@ The print and display classes can be combined.
{{< example >}}
<div class="d-print-none">Screen Only (Hide on print only)</div>
<div class="d-none d-print-block">Print Only (Hide on screen only)</div>
<!--<div class="d-none d-lg-block d-print-block">Hide up to large on screen, but always show on print</div>-->
{{< /example >}}

<!--<div class="d-none d-lg-block d-print-block">Hide up to large on screen, but always show on print</div>-->
hannahiss marked this conversation as resolved.
Show resolved Hide resolved

## CSS

### Sass utilities API
Expand Down
Loading