Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit a11y: Change wrong images labels #2709

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Fix audit a11y: Change wrong images labels #2709

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b23833
Change wrong images labels
hannahiss Aug 23, 2024
8d11c59
Merge branch 'main' into main-his-wrong-img-labels
hannahiss Sep 6, 2024
2155575
replace full by master
hannahiss Sep 6, 2024
d00ab4b
use "small" wording like in figcaption
hannahiss Sep 6, 2024
4eea692
Merge branch 'main' into main-his-wrong-img-labels
hannahiss Sep 10, 2024
d2295d2
Rollback change of aria-label on SVG tooltip, since it will come back…
hannahiss Sep 10, 2024
cd500d1
Merge remote-tracking branch 'origin/main-his-wrong-img-labels' into …
hannahiss Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/content/docs/5.3/about/brand.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ Have a need for Boosted's brand resources? Great! We have only a few guidelines
<div class="col">
<div class="ratio ratio-1x1">
<figure class="d-flex bg-black">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" class="figure-img img-fluid m-auto" width="220" height="220" role="img" alt="Orange" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" class="figure-img img-fluid m-auto" width="220" height="220" role="img" alt="Orange master logo" loading="lazy">
<figcaption class="figure-caption fw-bold position-absolute">Master logo</figcaption>
</figure>
</div>
</div>
<div class="col">
<div class="ratio ratio-1x1">
<figure class="d-flex bg-black">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" class="figure-img m-auto" width="30" height="30" role="img" alt="Orange" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/orange-logo.svg" class="figure-img m-auto" width="30" height="30" role="img" alt="Orange small logo" loading="lazy">
<figcaption class="figure-caption fw-bold position-absolute">Small logo</figcaption>
</figure>
</div>
Expand All @@ -49,7 +49,7 @@ Orange Business Services has its own logo that contains the Orange logo and the
<div class="col">
<div class="ratio ratio-1x1">
<figure class="d-flex bg-black">
<img src="/docs/{{< param docs_version >}}/assets/brand/OBS-logo.svg" class="figure-img img-fluid m-auto" width="220" height="220" role="img" alt="Orange" loading="lazy">
<img src="/docs/{{< param docs_version >}}/assets/brand/OBS-logo.svg" class="figure-img img-fluid m-auto" width="220" height="220" role="img" alt="Orange Business Services logo" loading="lazy">
<figcaption class="figure-caption fw-bold position-absolute">Orange Business Services logo</figcaption>
</figure>
</div>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/5.3/components/tooltips.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ With an SVG:
<!--Boosted mod: added an aria-label="Default tooltip" because the title is automatically removed by JS-->

<div class="bd-example tooltip-demo">
<a href="#" class="d-inline-block" data-bs-toggle="tooltip" data-bs-title="Default tooltip" aria-label="Default tooltip">
<a href="#" class="d-inline-block" data-bs-toggle="tooltip" data-bs-title="Default tooltip" aria-label="Focus or hover to open default tooltip">
julien-deramond marked this conversation as resolved.
Show resolved Hide resolved
<svg xmlns="http://www.w3.org/2000/svg" width="50" height="50" viewBox="0 0 100 100" aria-hidden="true">
<rect width="100%" height="100%" fill="#563d7c"/>
<circle cx="50" cy="50" r="30" fill="#007bff"/>
Expand Down
Loading