-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a11y audit 3-2: Update aria-label
and title
#2703
Conversation
aria-label
and title
aria-label
and title
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reviewing, I thought about "Visit Design system for web at system.design.orange.com", which I find more comprehensive?
What do you think?
Nitpicking here, but "for web" is not really accurate. |
😄 you're right! So maybe "Visit Orange Design System at system.design.orange.com" or change the link... |
I vote for "Visit Orange Design System at system.design.orange.com". LGTM. |
Related issues
#2667 3-2
Description
Motivation & Context
Read the related issue. More consistency and better understanding for people.
Types of change
Live previews