Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit 3-2: Update aria-label and title #2703

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

louismaximepiton
Copy link
Member

Related issues

#2667 3-2

Description

  • Update the aria-label and the title.

Motivation & Context

Read the related issue. More consistency and better understanding for people.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

@louismaximepiton louismaximepiton added v5 accessibility docs Improvements or additions to documentation labels Aug 22, 2024
@louismaximepiton louismaximepiton changed the title Fix a11y ausit 3-2: Update aria-label and title Fix a11y audit 3-2: Update aria-label and title Aug 22, 2024
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 55a2517
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66fd4aefa73479000863c99d
😎 Deploy Preview https://deploy-preview-2703--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reviewing, I thought about "Visit Design system for web at system.design.orange.com", which I find more comprehensive?
What do you think?

@julien-deramond
Copy link
Contributor

When reviewing, I thought about "Visit Design system for web at system.design.orange.com", which I find more comprehensive? What do you think?

Nitpicking here, but "for web" is not really accurate. system.design.orange.com is the entire design system, and is not "for web". Otherwise, the URL would have been https://system.design.orange.com/0c1af118d/p/8118d1-web, that targets directly only the web universe of our design system.

@hannahiss
Copy link
Member

hannahiss commented Sep 6, 2024

Nitpicking here, but "for web" is not really accurate. system.design.orange.com is the entire design system, and is not "for web". Otherwise, the URL would have been https://system.design.orange.com/0c1af118d/p/8118d1-web, that targets directly only the web universe of our design system.

😄 you're right! So maybe "Visit Orange Design System at system.design.orange.com" or change the link...

@julien-deramond
Copy link
Contributor

"Visit Orange Design System at system.design.orange.com"

I vote for "Visit Orange Design System at system.design.orange.com". LGTM.

@julien-deramond julien-deramond self-requested a review October 2, 2024 13:31
@julien-deramond julien-deramond merged commit 767a1c3 into main Oct 2, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-a11y-3-2-aria-label branch October 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants