Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit 0-6: focus order for the copy button on code example #2699

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 20, 2024

Related issues

#2667 0-6

Description

Motivation & Context

Read the related issue. The focus was on the copy button before the code.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

@louismaximepiton louismaximepiton added v5 js Pull requests that update Javascript code accessibility docs Improvements or additions to documentation labels Aug 20, 2024
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5591277
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/670d0c3ca318cd00082796da
😎 Deploy Preview https://deploy-preview-2699--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton changed the title Fix focus order for the copy button on code example only Fix a11y audit 0-6: focus order for the copy button on code example Aug 20, 2024
Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great focus order thx!

@julien-deramond
Copy link
Member

In https://deploy-preview-2699--boosted.netlify.app/docs/5.3/docsref/, only the first example is handled this way. It's not possible to modify the focus order for the other ones too?

@louismaximepiton
Copy link
Member Author

I understand your point here, but the visual rendering is different between the examples and I think it could be hard to make the same focus order for each example you mention.

@louismaximepiton louismaximepiton marked this pull request as draft October 2, 2024 07:45
@louismaximepiton
Copy link
Member Author

Changed the focus order for each example, tell me if you think it's not too weird to manipulate and in the code as well.

@louismaximepiton louismaximepiton marked this pull request as ready for review October 2, 2024 15:44
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new focus order is great! I haven't particularly checked the modifications, as they are only for the documentation and are gathered in some specific recognizable files. Just added some Boosted mod comments for maintenance and sync with upstream project.

@julien-deramond julien-deramond merged commit 5b0b7d0 into main Oct 14, 2024
12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-a11y-0-6-focus-order branch October 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation js Pull requests that update Javascript code v5
Projects
Development

Successfully merging this pull request may close these issues.

4 participants