-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a11y audit 0-6: focus order for the copy button on code example #2699
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great focus order thx!
In https://deploy-preview-2699--boosted.netlify.app/docs/5.3/docsref/, only the first example is handled this way. It's not possible to modify the focus order for the other ones too? |
I understand your point here, but the visual rendering is different between the examples and I think it could be hard to make the same focus order for each example you mention. |
Changed the focus order for each example, tell me if you think it's not too weird to manipulate and in the code as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new focus order is great! I haven't particularly checked the modifications, as they are only for the documentation and are gathered in some specific recognizable files. Just added some Boosted mod comments for maintenance and sync with upstream project.
Related issues
#2667 0-6
Description
Motivation & Context
Read the related issue. The focus was on the copy button before the code.
Types of change
Live previews