Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit 5-4: figcaption color in dark mode #2697

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

louismaximepiton
Copy link
Member

Related issues

#2667 5-4

Description

  • Fix the figure caption color.

Motivation & Context

Read the related issue. The color wasn't switching between light and dark mode.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

@louismaximepiton louismaximepiton added v5 accessibility docs Improvements or additions to documentation labels Aug 20, 2024
Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 57c9a0c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66e28360296cb100086b2fc6
😎 Deploy Preview https://deploy-preview-2697--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hannahiss hannahiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@julien-deramond julien-deramond self-requested a review September 12, 2024 05:59
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice!

@julien-deramond julien-deramond merged commit f43e4c6 into main Sep 12, 2024
12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-a11y-5-4-figcaption-color branch September 12, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants