Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit: alt attribute of decorative images must be empty #2690

Merged
merged 22 commits into from
Oct 1, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Aug 19, 2024

The ALT attribute of a decorative image must be empty, so that the image is ignored by technical aids.

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#2667

Description

Remove alt content for the following images:

  • boosted-guidelines.png in home page
  • Parcel, Vite and Webpack logos in Getting started documentation
  • User picture in Orange navbar (since a visually hidden and better text "My account" already exists): empty alt, remove role="img", remove aria-hidden="true"

Motivation & Context

A11y audit fixes: these images are decorative, the alt must be empty so that assistive technologies ignore them.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

…be empty, so that the image is ignored by technical aids. Case of the image "boosted-guidelines.png" with alt="Boosted design guidelines". This image is decorative.
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d46ef21
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66fba166317072000849a878
😎 Deploy Preview https://deploy-preview-2690--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss changed the title Fix a11y audit bug 0-2: The ALT attribute of a decorative image must be empty Fix a11y audit: alt attribute of decorative images must be empty Aug 20, 2024
@hannahiss hannahiss marked this pull request as draft August 21, 2024 12:52
@hannahiss hannahiss added docs Improvements or additions to documentation v5 labels Aug 22, 2024
@hannahiss hannahiss marked this pull request as ready for review August 27, 2024 07:41
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, I don't know if it's the place to do it, but there are still some <img.*role=.img that I can find in the Scrollspy code.

@hannahiss
Copy link
Member Author

hannahiss commented Sep 9, 2024

I'm fine with it, I don't know if it's the place to do it, but there are still some <img.*role=.img that I can find in the Scrollspy code.

For info, the others have been treated in the PR #2704

hannahiss added a commit that referenced this pull request Sep 19, 2024
@julien-deramond
Copy link
Member

This PR have a lot of errors in the "Docs" workflow. @hannahiss could you please fix them?

@hannahiss
Copy link
Member Author

This PR have a lot of errors in the "Docs" workflow. @hannahiss could you please fix them?

Sorry, I didn't thought this would make some checks errors. It was already done in PR #2704

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last feedback, and we're good to go :)

site/layouts/shortcodes/orange-supra.html Outdated Show resolved Hide resolved
site/content/docs/5.3/migration.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review October 1, 2024 07:05
@julien-deramond julien-deramond merged commit 204e2a8 into main Oct 1, 2024
12 checks passed
@julien-deramond julien-deramond deleted the main-his-a11y-0-2-alt branch October 1, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs Improvements or additions to documentation v5
Projects
Development

Successfully merging this pull request may close these issues.

3 participants