-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a11y audit: alt attribute of decorative images must be empty #2690
Conversation
…be empty, so that the image is ignored by technical aids. Case of the image "boosted-guidelines.png" with alt="Boosted design guidelines". This image is decorative.
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with it, I don't know if it's the place to do it, but there are still some <img.*role=.img
that I can find in the Scrollspy code.
For info, the others have been treated in the PR #2704 |
This PR have a lot of errors in the "Docs" workflow. @hannahiss could you please fix them? |
Sorry, I didn't thought this would make some checks errors. It was already done in PR #2704 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last feedback, and we're good to go :)
remove useless aria-hidden Co-authored-by: Julien Déramond <[email protected]>
…-his-a11y-0-2-alt
The ALT attribute of a decorative image must be empty, so that the image is ignored by technical aids.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#2667
Description
Remove alt content for the following images:
Motivation & Context
A11y audit fixes: these images are decorative, the alt must be empty so that assistive technologies ignore them.
Types of change
Live previews