[OUDS] feat: Add 'Borders' token, utilities and documentation #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vprothais
changed the title
vprothais
commented
Aug 9, 2024
louismaximepiton
force-pushed
the
ouds/main-vp-border-token
branch
from
fe3cd7a to
0c094b8
Compare
24 tasks
| --#{$prefix}border-radius-2xl: var(--#{$prefix}border-radius-xxl); // Deprecated in Bootstrap v5.3.0 for consistency | ||
| --#{$prefix}border-radius-pill: #{$border-radius-pill}; | ||
| // scss-docs-start root-border-var | ||
| @if $enable-bootstrap-compatibility { |
There was a problem hiding this comment.
Let's let that like this for now, but this is not final, as a lot of Sass component variables depend on var(--bs-border-radius).
For instance, the header is a bit broken (active state of menu items) in our docs.
julien-deramond
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #2582
Linked to #2589
Description
Add Border utilities based on design tokens with corresponding documentation.
LM:
.border-pilland.border-circlein the doc but should surely be backported in Bootstrap as well.ouds/mainouds/main-vp-border-tokenouds-web.csssizeouds-web-bootstrapsizeouds-web-grid.csssizeouds-web-reboot.csssizeouds-web-utilities.csssizeTodo
To add to #2589
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge